Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Jérome Perrin
gitlab-ce
Commits
5b41b792
Commit
5b41b792
authored
Mar 17, 2017
by
James Edwards-Jones
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Prevented error on nil author from Issuable delegation
parent
1e5888d1
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
29 additions
and
0 deletions
+29
-0
app/models/concerns/issuable.rb
app/models/concerns/issuable.rb
+1
-0
spec/models/concerns/issuable_spec.rb
spec/models/concerns/issuable_spec.rb
+28
-0
No files found.
app/models/concerns/issuable.rb
View file @
5b41b792
...
@@ -50,6 +50,7 @@ module Issuable
...
@@ -50,6 +50,7 @@ module Issuable
:email
,
:email
,
:public_email
,
:public_email
,
to: :author
,
to: :author
,
allow_nil:
true
,
prefix:
true
prefix:
true
delegate
:name
,
delegate
:name
,
...
...
spec/models/concerns/issuable_spec.rb
View file @
5b41b792
...
@@ -44,6 +44,34 @@ describe Issue, "Issuable" do
...
@@ -44,6 +44,34 @@ describe Issue, "Issuable" do
it
{
expect
(
described_class
).
to
respond_to
(
:assigned
)
}
it
{
expect
(
described_class
).
to
respond_to
(
:assigned
)
}
end
end
describe
'author_name'
do
it
'is delegated to author'
do
expect
(
issue
.
author_name
).
to
eq
issue
.
author
.
name
end
it
'returns nil when author is nil'
do
issue
.
author_id
=
nil
issue
.
save
(
validate:
false
)
expect
(
issue
.
author_name
).
to
eq
nil
end
end
describe
'assignee_name'
do
it
'is delegated to assignee'
do
issue
.
update!
(
assignee:
create
(
:user
))
expect
(
issue
.
assignee_name
).
to
eq
issue
.
assignee
.
name
end
it
'returns nil when assignee is nil'
do
issue
.
assignee_id
=
nil
issue
.
save
(
validate:
false
)
expect
(
issue
.
assignee_name
).
to
eq
nil
end
end
describe
"before_save"
do
describe
"before_save"
do
describe
"#update_cache_counts"
do
describe
"#update_cache_counts"
do
context
"when previous assignee exists"
do
context
"when previous assignee exists"
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment