Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Jérome Perrin
gitlab-ce
Commits
87699616
Commit
87699616
authored
Sep 05, 2017
by
Winnie Hellmann
Committed by
Clement Ho
Sep 05, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Make search dropdowns consistent
parent
597b0517
Changes
4
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
190 additions
and
150 deletions
+190
-150
app/assets/javascripts/gl_dropdown.js
app/assets/javascripts/gl_dropdown.js
+9
-5
app/assets/stylesheets/framework/dropdowns.scss
app/assets/stylesheets/framework/dropdowns.scss
+1
-0
app/assets/stylesheets/pages/search.scss
app/assets/stylesheets/pages/search.scss
+2
-0
spec/javascripts/gl_dropdown_spec.js
spec/javascripts/gl_dropdown_spec.js
+178
-145
No files found.
app/assets/javascripts/gl_dropdown.js
View file @
87699616
...
...
@@ -637,11 +637,15 @@ GitLabDropdown = (function() {
value
=
this
.
options
.
id
?
this
.
options
.
id
(
data
)
:
data
.
id
;
fieldName
=
this
.
options
.
fieldName
;
if
(
value
)
{
value
=
value
.
toString
().
replace
(
/'/g
,
'
\\\'
'
);
}
field
=
this
.
dropdown
.
parent
().
find
(
"
input[name='
"
+
fieldName
+
"
'][value='
"
+
value
+
"
']
"
);
if
(
field
.
length
)
{
selected
=
true
;
if
(
value
)
{
value
=
value
.
toString
().
replace
(
/'/g
,
'
\\\'
'
);
field
=
this
.
dropdown
.
parent
().
find
(
`input[name='
${
fieldName
}
'][value='
${
value
}
']`
);
if
(
field
.
length
)
{
selected
=
true
;
}
}
else
{
field
=
this
.
dropdown
.
parent
().
find
(
`input[name='
${
fieldName
}
']`
);
selected
=
!
field
.
length
;
}
}
// Set URL
...
...
app/assets/stylesheets/framework/dropdowns.scss
View file @
87699616
...
...
@@ -766,6 +766,7 @@
box-shadow
:
none
;
padding
:
8px
16px
;
text-align
:
left
;
white-space
:
normal
;
width
:
100%
;
// make sure the text color is not overriden
...
...
app/assets/stylesheets/pages/search.scss
View file @
87699616
...
...
@@ -190,6 +190,8 @@ input[type="checkbox"]:hover {
}
.search-holder
{
@include
new-style-dropdown
;
@media
(
min-width
:
$screen-sm-min
)
{
display
:
-
webkit-flex
;
display
:
flex
;
...
...
spec/javascripts/gl_dropdown_spec.js
View file @
87699616
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment