Improve create_mr_button? performance.

a3edd473 · Douwe Maan · e80c4447 · a3edd473
Commit a3edd473 authored May 09, 2015 by Douwe Maan
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 5 deletions

app/helpers/compare_helper.rb app/helpers/compare_helper.rb +4 -5

No files found.
--- a/app/helpers/compare_helper.rb
+++ b/app/helpers/compare_helper.rb
 module CompareHelper
  def create_mr_button?(from = params[:from], to = params[:to], project = @project)
-    project.merge_requests_enabled &&
+    from.present? &&
-      from.present? &&
      to.present? &&
-      project.repository.branch_names.include?(from) &&
-      project.repository.branch_names.include?(to) &&
      from != to &&
-      !@refs_are_same
+      project.merge_requests_enabled &&
+      project.repository.branch_names.include?(from) &&
+      project.repository.branch_names.include?(to)
  end
  def create_mr_path(from = params[:from], to = params[:to], project = @project)