Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Jérome Perrin
gitlab-ce
Commits
aca0d610
Commit
aca0d610
authored
May 25, 2018
by
Phil Hughes
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fixed mutations spec
parent
cdc92d94
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
30 additions
and
33 deletions
+30
-33
app/assets/javascripts/ide/components/pipelines/list.vue
app/assets/javascripts/ide/components/pipelines/list.vue
+1
-1
app/assets/javascripts/ide/stores/modules/pipelines/mutations.js
...ets/javascripts/ide/stores/modules/pipelines/mutations.js
+8
-1
spec/javascripts/ide/mock_data.js
spec/javascripts/ide/mock_data.js
+4
-1
spec/javascripts/ide/stores/modules/pipelines/mutations_spec.js
...avascripts/ide/stores/modules/pipelines/mutations_spec.js
+17
-30
No files found.
app/assets/javascripts/ide/components/pipelines/list.vue
View file @
aca0d610
...
...
@@ -47,7 +47,7 @@ export default {
Pipeline
</strong>
<a
:href=
"latestPipeline.
details.status.details_
path"
:href=
"latestPipeline.path"
target=
"_blank"
>
#
{{
latestPipeline
.
id
}}
...
...
app/assets/javascripts/ide/stores/modules/pipelines/mutations.js
View file @
aca0d610
...
...
@@ -12,7 +12,14 @@ export default {
state
.
isLoadingPipeline
=
false
;
if
(
pipeline
)
{
state
.
latestPipeline
=
pipeline
;
state
.
latestPipeline
=
{
id
:
pipeline
.
id
,
path
:
pipeline
.
path
,
commit
:
pipeline
.
commit
,
details
:
{
status
:
pipeline
.
details
.
status
,
},
};
state
.
stages
=
pipeline
.
details
.
stages
.
map
((
stage
,
i
)
=>
{
const
foundStage
=
state
.
stages
.
find
(
s
=>
s
.
id
===
i
);
return
{
...
...
spec/javascripts/ide/mock_data.js
View file @
aca0d610
...
...
@@ -89,14 +89,16 @@ export const fullPipelinesResponse = {
pipelines
:
[
{
id
:
'
51
'
,
path
:
'
test
'
,
commit
:
{
id
:
'
xxxxxxxxxxxxxxxxxxxx
'
,
id
:
'
123
'
,
},
details
:
{
status
:
{
icon
:
'
status_failed
'
,
text
:
'
failed
'
,
},
stages
:
[...
stages
],
},
},
{
...
...
@@ -109,6 +111,7 @@ export const fullPipelinesResponse = {
icon
:
'
status_passed
'
,
text
:
'
passed
'
,
},
stages
:
[...
stages
],
},
},
],
...
...
spec/javascripts/ide/stores/modules/pipelines/mutations_spec.js
View file @
aca0d610
import
mutations
from
'
~/ide/stores/modules/pipelines/mutations
'
;
import
state
from
'
~/ide/stores/modules/pipelines/state
'
;
import
*
as
types
from
'
~/ide/stores/modules/pipelines/mutation_types
'
;
import
{
pipelines
,
stages
}
from
'
../../../mock_data
'
;
import
{
fullPipelinesResponse
,
stages
}
from
'
../../../mock_data
'
;
describe
(
'
IDE pipelines mutations
'
,
()
=>
{
let
mockedState
;
...
...
@@ -28,17 +28,25 @@ describe('IDE pipelines mutations', () => {
describe
(
types
.
RECEIVE_LASTEST_PIPELINE_SUCCESS
,
()
=>
{
it
(
'
sets loading to false on success
'
,
()
=>
{
mutations
[
types
.
RECEIVE_LASTEST_PIPELINE_SUCCESS
](
mockedState
,
pipelines
[
0
]);
mutations
[
types
.
RECEIVE_LASTEST_PIPELINE_SUCCESS
](
mockedState
,
fullPipelinesResponse
.
data
.
pipelines
[
0
],
);
expect
(
mockedState
.
isLoadingPipeline
).
toBe
(
false
);
});
it
(
'
sets latestPipeline
'
,
()
=>
{
mutations
[
types
.
RECEIVE_LASTEST_PIPELINE_SUCCESS
](
mockedState
,
pipelines
[
0
]);
mutations
[
types
.
RECEIVE_LASTEST_PIPELINE_SUCCESS
](
mockedState
,
fullPipelinesResponse
.
data
.
pipelines
[
0
],
);
expect
(
mockedState
.
latestPipeline
).
toEqual
({
id
:
pipelines
[
0
].
id
,
status
:
pipelines
[
0
].
status
,
id
:
'
51
'
,
path
:
'
test
'
,
commit
:
{
id
:
'
123
'
},
details
:
{
status
:
jasmine
.
any
(
Object
)
},
});
});
...
...
@@ -47,33 +55,12 @@ describe('IDE pipelines mutations', () => {
expect
(
mockedState
.
latestPipeline
).
toEqual
(
null
);
});
});
describe
(
types
.
REQUEST_STAGES
,
()
=>
{
it
(
'
sets stages loading to true
'
,
()
=>
{
mutations
[
types
.
REQUEST_STAGES
](
mockedState
);
expect
(
mockedState
.
isLoadingJobs
).
toBe
(
true
);
});
});
describe
(
types
.
RECEIVE_STAGES_ERROR
,
()
=>
{
it
(
'
sets jobs loading to false
'
,
()
=>
{
mutations
[
types
.
RECEIVE_STAGES_ERROR
](
mockedState
);
expect
(
mockedState
.
isLoadingJobs
).
toBe
(
false
);
});
});
describe
(
types
.
RECEIVE_STAGES_SUCCESS
,
()
=>
{
it
(
'
sets jobs loading to false on success
'
,
()
=>
{
mutations
[
types
.
RECEIVE_STAGES_SUCCESS
](
mockedState
,
stages
);
expect
(
mockedState
.
isLoadingJobs
).
toBe
(
false
);
});
it
(
'
sets stages
'
,
()
=>
{
mutations
[
types
.
RECEIVE_STAGES_SUCCESS
](
mockedState
,
stages
);
mutations
[
types
.
RECEIVE_LASTEST_PIPELINE_SUCCESS
](
mockedState
,
fullPipelinesResponse
.
data
.
pipelines
[
0
],
);
expect
(
mockedState
.
stages
.
length
).
toBe
(
2
);
expect
(
mockedState
.
stages
).
toEqual
([
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment