Commit b3917d48 authored by Bryce Johnson's avatar Bryce Johnson

Set defaults in constructor, in case opts are undefined.

parent 7beb9f34
...@@ -14,9 +14,9 @@ ...@@ -14,9 +14,9 @@
global.BlobCiYamlSelector = BlobCiYamlSelector; global.BlobCiYamlSelector = BlobCiYamlSelector;
class BlobCiYamlSelectors { class BlobCiYamlSelectors {
constructor({ editor, $dropdowns = $('.js-gitlab-ci-yml-selector') }) { constructor({ editor, $dropdowns }) {
this.editor = editor; this.editor = editor;
this.$dropdowns = $dropdowns; this.$dropdowns = $dropdowns || $('.js-gitlab-ci-yml-selector');
this.initSelectors(); this.initSelectors();
} }
......
((global) => { ((global) => {
class Profile { class Profile {
constructor({ form = $('.edit-user') } = {}) { constructor({ form }) {
this.onSubmitForm = this.onSubmitForm.bind(this); this.onSubmitForm = this.onSubmitForm.bind(this);
this.form = form; this.form = form || $('.edit-user');
this.bindEvents(); this.bindEvents();
this.initAvatarGlCrop(); this.initAvatarGlCrop();
} }
......
...@@ -9,20 +9,13 @@ ...@@ -9,20 +9,13 @@
}; };
class SearchAutocomplete { class SearchAutocomplete {
constructor({ constructor({ wrap, optsEl, autocompletePath, projectId, projectRef }) {
wrap = $('.search'),
optsEl = wrap.find('.search-autocomplete-opts'),
autocompletePath = optsEl.data('autocomplete-path'),
projectId = (optsEl.data('autocomplete-project-id') || ''),
projectRef = (optsEl.data('autocomplete-project-ref') || '')
} = {}) {
this.bindEventContext(); this.bindEventContext();
this.wrap = wrap; this.wrap = wrap || $('.search');
this.optsEl = optsEl; this.optsEl = optsEl || wrap.find('.search-autocomplete-opts');
this.autocompletePath = autocompletePath; this.autocompletePath = autocompletePath || optsEl.data('autocomplete-path');
this.projectId = projectId; this.projectId = projectId || (optsEl.data('autocomplete-project-id') || '');
this.projectRef = projectRef; this.projectRef = projectRef || (optsEl.data('autocomplete-project-ref') || '');
this.dropdown = wrap.find('.dropdown'); this.dropdown = wrap.find('.dropdown');
this.dropdownContent = this.dropdown.find('.dropdown-content'); this.dropdownContent = this.dropdown.find('.dropdown-content');
this.locationBadgeEl = this.getElement('.location-badge'); this.locationBadgeEl = this.getElement('.location-badge');
......
((global) => { ((global) => {
class Todos { class Todos {
constructor({ el = $('.js-todos-options') }) { constructor({ el }) {
this.allDoneClicked = this.allDoneClicked.bind(this); this.allDoneClicked = this.allDoneClicked.bind(this);
this.doneClicked = this.doneClicked.bind(this); this.doneClicked = this.doneClicked.bind(this);
this.el = el; this.el = el || $('.js-todos-options');
this.perPage = el.data('perPage'); this.perPage = el.data('perPage');
this.clearListeners(); this.clearListeners();
this.initBtnListeners(); this.initBtnListeners();
......
...@@ -59,10 +59,10 @@ content on the Users#show page. ...@@ -59,10 +59,10 @@ content on the Users#show page.
*/ */
((global) => { ((global) => {
class UserTabs { class UserTabs {
constructor ({ defaultAction = 'activity', action = defaultAction, parentEl }) { constructor ({ defaultAction, action, parentEl }) {
this.loaded = {}; this.loaded = {};
this.defaultAction = defaultAction; this.defaultAction = defaultAction || 'activity';
this.action = action; this.action = action || this.defaultAction;
this.$parentEl = $(parentEl) || $(document); this.$parentEl = $(parentEl) || $(document);
this._location = window.location; this._location = window.location;
this.$parentEl.find('.nav-links a') this.$parentEl.find('.nav-links a')
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment