Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Jérome Perrin
gitlab-ce
Commits
dc55127c
Commit
dc55127c
authored
Apr 29, 2014
by
Dmitriy Zaporozhets
Browse files
Options
Browse Files
Download
Plain Diff
Merge branch 'refresh_unless_hidden' into 'master'
Refresh Notes unless the tab is hidden
parents
c7dc20c1
c8cf90d2
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
12 additions
and
1 deletion
+12
-1
CHANGELOG
CHANGELOG
+1
-0
app/assets/javascripts/notes.js.coffee
app/assets/javascripts/notes.js.coffee
+11
-1
No files found.
CHANGELOG
View file @
dc55127c
...
@@ -7,6 +7,7 @@ v 6.9.0
...
@@ -7,6 +7,7 @@ v 6.9.0
- Add ability to set different ssh host, if different from http/https
- Add ability to set different ssh host, if different from http/https
- Fix syntax highlighting for code comments blocks
- Fix syntax highlighting for code comments blocks
- Improve comments loading logic
- Improve comments loading logic
- Stop refreshing comments when the tab is hidden
v 6.8.0
v 6.8.0
- Ability to at mention users that are participating in issue and merge req. discussion
- Ability to at mention users that are participating in issue and merge req. discussion
...
...
app/assets/javascripts/notes.js.coffee
View file @
dc55127c
...
@@ -50,6 +50,9 @@ class Notes
...
@@ -50,6 +50,9 @@ class Notes
# hide diff note form
# hide diff note form
$
(
document
).
on
"click"
,
".js-close-discussion-note-form"
,
@
cancelDiscussionForm
$
(
document
).
on
"click"
,
".js-close-discussion-note-form"
,
@
cancelDiscussionForm
# fetch notes when tab becomes visible
$
(
document
).
on
"visibilitychange"
,
@
visibilityChange
cleanBinding
:
->
cleanBinding
:
->
$
(
document
).
off
"ajax:success"
,
".js-main-target-form"
$
(
document
).
off
"ajax:success"
,
".js-main-target-form"
$
(
document
).
off
"ajax:success"
,
".js-discussion-note-form"
$
(
document
).
off
"ajax:success"
,
".js-discussion-note-form"
...
@@ -63,6 +66,7 @@ class Notes
...
@@ -63,6 +66,7 @@ class Notes
$
(
document
).
off
"click"
,
".js-choose-note-attachment-button"
$
(
document
).
off
"click"
,
".js-choose-note-attachment-button"
$
(
document
).
off
"click"
,
".js-discussion-reply-button"
$
(
document
).
off
"click"
,
".js-discussion-reply-button"
$
(
document
).
off
"click"
,
".js-add-diff-note-button"
$
(
document
).
off
"click"
,
".js-add-diff-note-button"
$
(
document
).
off
"visibilitychange"
initRefresh
:
->
initRefresh
:
->
...
@@ -72,7 +76,7 @@ class Notes
...
@@ -72,7 +76,7 @@ class Notes
,
15000
,
15000
refresh
:
->
refresh
:
->
@
getContent
()
@
getContent
()
unless
document
.
hidden
getContent
:
->
getContent
:
->
$
.
ajax
$
.
ajax
...
@@ -453,4 +457,10 @@ class Notes
...
@@ -453,4 +457,10 @@ class Notes
filename
=
$
(
this
).
val
().
replace
(
/^.*[\\\/]/
,
""
)
filename
=
$
(
this
).
val
().
replace
(
/^.*[\\\/]/
,
""
)
form
.
find
(
".js-attachment-filename"
).
text
filename
form
.
find
(
".js-attachment-filename"
).
text
filename
###
Called when the tab visibility changes
###
visibilityChange
:
=>
@
refresh
()
@
Notes
=
Notes
@
Notes
=
Notes
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment