Commit f4746d01 authored by Phil Hughes's avatar Phil Hughes

Variables renames

parent e786c2b2
...@@ -11,15 +11,15 @@ ...@@ -11,15 +11,15 @@
}, },
data: function() { data: function() {
return { return {
comments: CommentsStore.state, discussions: CommentsStore.state,
loadingObject: CommentsStore.loading, loadingObject: CommentsStore.loading,
}; };
}, },
computed: { computed: {
allResolved: function () { allResolved: function () {
let isResolved = true; let isResolved = true;
for (const noteId in this.comments[this.discussionId]) { for (const noteId in this.discussions[this.discussionId]) {
const resolved = this.comments[this.discussionId][noteId].resolved; const resolved = this.discussions[this.discussionId][noteId].resolved;
if (!resolved) { if (!resolved) {
isResolved = false; isResolved = false;
......
...@@ -14,7 +14,7 @@ ...@@ -14,7 +14,7 @@
}, },
data: function () { data: function () {
return { return {
comments: CommentsStore.state, discussions: CommentsStore.state,
loading: false loading: false
}; };
}, },
...@@ -37,7 +37,7 @@ ...@@ -37,7 +37,7 @@
}, },
resolve: function () { resolve: function () {
if (!this.canResolve) return; if (!this.canResolve) return;
let promise; let promise;
this.loading = true; this.loading = true;
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
w.ResolveCount = Vue.extend({ w.ResolveCount = Vue.extend({
data: function () { data: function () {
return { return {
comments: CommentsStore.state, discussions: CommentsStore.state,
loading: false loading: false
}; };
}, },
...@@ -29,8 +29,8 @@ ...@@ -29,8 +29,8 @@
return resolvedCount; return resolvedCount;
}, },
commentsCount: function () { discussionCount: function () {
return Object.keys(this.comments).length; return Object.keys(this.discussions).length;
}, },
allResolved: function () { allResolved: function () {
return this.resolved === this.commentsCount; return this.resolved === this.commentsCount;
......
...@@ -49,7 +49,7 @@ ...@@ -49,7 +49,7 @@
%resolve-count{ "inline-template" => true } %resolve-count{ "inline-template" => true }
.line-resolve-all{ "v-show" => "commentsCount > 0" } .line-resolve-all{ "v-show" => "commentsCount > 0" }
%span.line-resolve-text %span.line-resolve-text
{{ resolved }}/{{ commentsCount }} discussions resolved {{ resolved }}/{{ discussionCount }} discussions resolved
- if @commits_count.nonzero? - if @commits_count.nonzero?
%ul.merge-request-tabs.nav-links.no-top.no-bottom %ul.merge-request-tabs.nav-links.no-top.no-bottom
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment