- 01 Sep, 2017 40 commits
-
-
Robert Speicher authored
We were incorrectly stubbing `Issues::MoveService#execute`. This only caused a failure when another spec caused it to be autoloaded -- `spec/controllers/projects/issues_controller_spec.rb` in this case.
-
Robert Speicher authored
-
Robert Speicher authored
Add settings for minimum key strength and allowed key type Closes #17849 See merge request !13712
-
Robert Speicher authored
Remove issuable finder count caching See merge request !13959
-
Clement Ho authored
Make pipeline dropdowns consistent See merge request !13530
-
Sean McGivern authored
Reduce duration and complexity of spec/features/issues/filtered_search/filter_issues_spec.rb See merge request !13973
-
Robert Speicher authored
Optimize notification emails specs See merge request !13986
-
Filipa Lacerda authored
Fixes the fly-out navigation flashing in & out Closes #37022 See merge request !13929
-
Robert Speicher authored
The assignee wasn't important to the test, and shortening the query allowed us to avoid the "horizontal scroll" failure without having to stub the `sidebar_collapsed?` helper.
-
Robert Speicher authored
We now document that fact.
-
Robert Speicher authored
-
Robert Speicher authored
We were essentially testing "all of the filters" four times, so now we just do it once at the top level.
-
Robert Speicher authored
-
Robert Speicher authored
-
Robert Speicher authored
-
Robert Speicher authored
-
Robert Speicher authored
-
Robert Speicher authored
Three issues were only used in one test each, and one milestone with its accompanying issue were only used in one test, so we now scope those locally.
-
Robert Speicher authored
Removes unnecessary `let!` usage since we explicitly access these in the `before. Re-uses `user2` as the author for issues we otherwise don't care about the author for, to avoid creating a new user in each one. Makes use of the `labeled_issue` factory to avoid assigning variables just so we can add labels to an issue.
-
Robert Speicher authored
This seemed to only exist to increment an issue counter by 1.
-
Robert Speicher authored
-
Robert Speicher authored
Only one context tested group behavior, but we were performing group and membership creation on every example unnecessarily.
-
Robert Speicher authored
-
Robert Speicher authored
-
Robert Speicher authored
While testing the various search tokens, we would add the token and a search term, then verify the correct issues were returned. Then we'd add a new token, search again, and verify again. Then another, and another. This was entirely redundant. If the search with higher specificity returned the same results as the search with lower specificity, we can be sure the lower specificity searches also worked without actually testing them. Because this entire spec performs very extensive setup, it's important to limit the number of times we perform that setup.
-
Douwe Maan authored
Validate PO files in static analysis See merge request !13000
-
Marcia Ramos authored
Add perforce migration doc See merge request !13890
-
Douwe Maan authored
Simplify Git interactions in AfterImportService See merge request !13962
-
Jacob Vosmaer (GitLab) authored
-
Grzegorz Bizon authored
-
Douwe Maan authored
Rollback changes made to signing_enabled. Closes #37202 See merge request !13956
-
Douwe Maan authored
Changed message and title on the 404 page See merge request !13982
-
Bob Van Landuyt authored
-
Sean McGivern authored
Fixed group merge requests failure See merge request !13985
-
Phil Hughes authored
Make member permission dropdowns consistent See merge request !13600
-
Sean McGivern authored
Merge request to address /move functionality. See merge request !13436
-
Sean McGivern authored
Use Gitaly 0.36.0 See merge request !13961
-
Kamil Trzciński authored
Backport to CE: Support `codequality` job name for Code Quality feature See merge request !13833
-
Grzegorz Bizon authored
-
Sean McGivern authored
Add 'from commit' information to cherry-picked commits See merge request !13475
-