Prior, if a user had 2FA enabled and checked the "Remember me" field,
the setting was ignored because the OTP input was on a new form and the
value was never passed.

Closes #18000

Enable Style/SpaceBeforeComma rubocop cop

No spaces before commas.

See #17478

See merge request !4360

Enable Performance/TimesMap Rubocop cop

Use Array.new with a block instead of `.times.collect` / `.times.map`.

See #17478

See merge request !4357

Enable Style/NegatedIf Rubocop cop

Favor `unless` over `if` for negative conditions (or control flow ||).

```ruby
# bad
do_something if !some_condition
# bad
do_something if not some_condition

# good
do_something unless some_condition
# good
some_condition || do_something
```

See #17478

See merge request !4355

Enable Lint/LiteralInCondition rubocop cop

Detects literals used in conditions.

See #17478

See merge request !4354

Enable Style/MultilineIfThen rubocop cop

Do not use then for multi-line if.

See #7478.

See merge request !4353

Enable Style/MethodDefParentheses rubocop cop

Use def with parentheses when there are parameters.

See #17478

See merge request !4352

Enable Style/IndentAssignment Rubocop style cop

Checks the indentation of the first line of the right-hand-side of a multi-line assignment.

See #17478

See merge request !4348

Enable Style/WhileUntilDo rubocop style cop

Checks for redundant `do` after `while` or `until`.

See #17478

See merge request !4350

Enable Style/EndOfLine Rubocop style cop

Use Unix-style line endings.

Removed carriage return character from end of each line in `app/controllers/projects/find_file_controller.rb`

See #17478

See merge request !4347

Enable Lint/BlockAlignment Rubocop cop

See #17478

See merge request !4346

Enable Style/RedundantParentheses rubocop cop

Checks for parentheses that seem not to serve any purpose.

See #17478 

See merge request !4361

Enable Style/SpaceBeforeComment rubocop cop

See #17478 

See merge request !4358

Enable Style/SpaceAfterMethodName rubocop cop

Do not put a space between a method name and the opening parenthesis  in a method definition.

See #17478

See merge request !4359

See #17478

No spaces before commas.

See #17478

See #17478

See #17478

Use Array.new with a block instead of `.times.collect` / `.times.map`.

See #17478

Favor `unless` over `if` for negative conditions
(or control flow ||).

See #17478

Checks of literals used in conditions.

See #17478

Do not use then for multi-line if.

See #7478.

Use def with parentheses when there are parameters.

See #17478

See #17478

Add DB index on users.state

See merge request !4336

See #17478

Use Unix-style line endings. See #17478.

See #17478

Closes #17920

Improve note validation

This MR improves note validation. Originates from #15577.

Closes #17260

See merge request !4024

❤

Use absolute paths in .gitignore

See merge request !4335

It's working fine now but by making it more explicit we can make tools
like 'The Silver Searcher' to parse properly the .gitignore file