1. 06 Sep, 2016 2 commits
    • Lin Jen-Shin's avatar
    • Lin Jen-Shin's avatar
      Merge remote-tracking branch 'upstream/master' into pipeline-hooks · ad0511f5
      Lin Jen-Shin authored
      * upstream/master: (368 commits)
        Don't fail on an empty database
        Refactor authorization_for_merge_requests.md
        Support MySQL too, when removing gitorious from import_sources
        Remove gitorious from import_sources on ApplicationSetting model
        Add links to new docs in merge_requests.md and workflow/README.md
        Move merge request versions to its own document
        Move "Only allow merge requests to be merged if the build succeeds" to new location
        Move revert_changes.md to new location
        Move cherry_pick_changes.md to new location
        Move `wip_merge_requests.md` to a new location
        Move merge_when_build_succeeds.md to new location
        Fix missing flash messages on service edit page
        Move authorization_for_merge_requests.md to new location
        Move `workflow/merge_requests.md` to `user/project/merge_requests.md`
        Update README.md
        Fix randomly failing specs in expand_collapse_diff_spec:
        Add link on API docs index page
        Move CHANGELOG entries of !5361, !5451 and !5887 from 8.11 to 8.12
        Remove suggested colors hover underline
        Fix markdown anchor icon interaction
        ...
      ad0511f5
  2. 05 Sep, 2016 23 commits
  3. 04 Sep, 2016 3 commits
    • Achilleas Pipinellis's avatar
      Merge branch 'zj-add-link-docs-index' into 'master' · beb0b666
      Achilleas Pipinellis authored
      Add link on API docs index page
      
      
      
      See merge request !6190
      beb0b666
    • Stan Hu's avatar
      Merge branch 'fix-spec-failures-diff-spec' into 'master' · 03acf759
      Stan Hu authored
      Fix randomly failing specs in expand_collapse_diff_spec:
      
      This MR fixes the following random failure in a spec:
      
      ```
       Failure/Error: namespace.human_name + ' / ' + name
      
           ActionView::Template::Error:
             undefined method `+' for nil:NilClass
           # ./app/models/project.rb:807:in `name_with_namespace'
           # ./app/views/layouts/project.html.haml:1:in `_app_views_layouts_project_html_haml___2918737809244135908_70160161538920
      '
           # ./app/controllers/projects/commit_controller.rb:23:in `show'
           # ./lib/gitlab/request_profiler/middleware.rb:15:in `call'
           # ./lib/gitlab/middleware/go.rb:16:in `call'
           # ./lib/gitlab/middleware/static.rb:9:in `call'
           # ------------------
      
           # --- Caused by: ---
           # NoMethodError:
           #   undefined method `+' for nil:NilClass
           #   ./app/models/project.rb:807:in `name_with_namespace'
      ```
      
      Capybara's `click_link` method doesn't actually wait for the page to reload.
      When the `expand_all_diffs` parameter is used, we need to search for unique
      elements that appear to ensure that the page has actually reloaded.
      
      Closes #21841
      
      See merge request !6193
      03acf759
    • Stan Hu's avatar
      Fix randomly failing specs in expand_collapse_diff_spec: · 49b9d8ae
      Stan Hu authored
      ```
       Failure/Error: namespace.human_name + ' / ' + name
      
           ActionView::Template::Error:
             undefined method `+' for nil:NilClass
           # ./app/models/project.rb:807:in `name_with_namespace'
           # ./app/views/layouts/project.html.haml:1:in `_app_views_layouts_project_html_haml___2918737809244135908_70160161538920
      '
           # ./app/controllers/projects/commit_controller.rb:23:in `show'
           # ./lib/gitlab/request_profiler/middleware.rb:15:in `call'
           # ./lib/gitlab/middleware/go.rb:16:in `call'
           # ./lib/gitlab/middleware/static.rb:9:in `call'
           # ------------------
      
           # --- Caused by: ---
           # NoMethodError:
           #   undefined method `+' for nil:NilClass
           #   ./app/models/project.rb:807:in `name_with_namespace'
      ```
      
      Capybara's `click_link` method doesn't actually wait for the page to reload.
      When the `expand_all_diffs` parameter is used, we need to search for unique
      elements that appear to ensure that the page has actually reloaded.
      
      Closes #21841
      49b9d8ae
  4. 03 Sep, 2016 1 commit
  5. 02 Sep, 2016 11 commits