set-up infrastructure to write tests with a real http server, and reproduced issue 163.

--HG-- branch : distribute extra : rebase_source : dc3a9fb1663500c66febacbc2ede43eaa96c190e

set-up infrastructure to write tests with a real http server, and reproduced issue 163.
--HG-- branch : distribute extra : rebase_source : dc3a9fb1663500c66febacbc2ede43eaa96c190e
29ffeae7 · Christophe Combelles · 17502a06 · 29ffeae7 · 29ffeae7 · 29ffeae7
Commit 29ffeae7 authored May 19, 2010 by Christophe Combelles
5 changed files
--- a/.hgignore
+++ b/.hgignore
@@ -10,3 +10,4 @@ lib
 bin
 include
 \.Python
+*.swp
--- a/setuptools/tests/indexes/test_links_priority/external.html
+++ b/setuptools/tests/indexes/test_links_priority/external.html
+<html><body>
+<a href="foobar-0.1.tar.gz#md5=bad_md5">bad old link</a>
+</body></html>
--- a/setuptools/tests/indexes/test_links_priority/simple/foobar/index.html
+++ b/setuptools/tests/indexes/test_links_priority/simple/foobar/index.html
+<html><body>
+<a href="foobar-0.1.tar.gz#md5=correct_md5">foobar-0.1.tar.gz</a><br/>
+<a href="../../external.html" rel="homepage">external homepage</a><br/>
+</body></html>
--- a/setuptools/tests/server.py
+++ b/setuptools/tests/server.py
+"""Basic http server for tests to simulate PyPI or custom indexes
+"""
+import urllib2
+from threading import Thread
+from BaseHTTPServer import HTTPServer
+from SimpleHTTPServer import SimpleHTTPRequestHandler
+
+class IndexServer(HTTPServer):
+    """Basic single-threaded http server simulating a package index
+
+    You can use this server in unittest like this::
+        s = IndexServer()
+        s.start()
+        index_url = s.base_url() + 'mytestindex'
+        # do some test requests to the index
+        s.stop()
+    """
+    def __init__(self):
+        HTTPServer.__init__(self, ('', 0), SimpleHTTPRequestHandler)
+        self._run = True
+
+    def serve(self):
+        while True:
+            self.handle_request()
+            if not self._run: break
+
+    def start(self):
+        self.thread = Thread(target=self.serve)
+        self.thread.start()
+
+    def stop(self):
+        """self.shutdown is not supported on python < 2.6"""
+        self._run = False
+        urllib2.urlopen('http://127.0.0.1:%s/' % self.server_address[1])
+        self.thread.join()
+
+    def base_url(self):
+        port = self.server_address[1]
+        return 'http://127.0.0.1:%s/setuptools/tests/indexes/' % port
--- a/setuptools/tests/test_packageindex.py
+++ b/setuptools/tests/test_packageindex.py
@@ -5,6 +5,7 @@ import sys
 import os, shutil, tempfile, unittest, urllib2
 import pkg_resources
 import setuptools.package_index
+from server import IndexServer

 class TestPackageIndex(unittest.TestCase):

@@ -74,3 +75,40 @@ class TestPackageIndex(unittest.TestCase):
        url = 'file:///tmp/test_package_index'
        self.assert_(index.url_ok(url, True))

+    def test_links_priority(self):
+        """
+        Download links from the pypi simple index should be used before
+        external download links.
+        http://bitbucket.org/tarek/distribute/issue/163/md5-validation-error
+
+        Usecase :
+        - someone uploads a package on pypi, a md5 is generated
+        - someone manually copies this link (with the md5 in the url) onto an
+          external page accessible from the package page.
+        - someone reuploads the package (with a different md5)
+        - while easy_installing, an MD5 error occurs because the external link
+          is used
+        -> Distribute should use the link from pypi, not the external one.
+        """
+        # start an index server
+        server = IndexServer()
+        server.start()
+        index_url = server.base_url() + 'test_links_priority/simple/'
+
+        # scan a test index
+        pi = setuptools.package_index.PackageIndex(index_url)
+        requirement = pkg_resources.Requirement.parse('foobar')
+        pi.find_packages(requirement)
+        server.stop()
+
+        # the distribution has been found
+        self.assert_('foobar' in pi)
+        # we have two links
+        self.assert_(len(pi['foobar'])==2)
+        # the first link should be from the index
+        self.assert_('correct_md5' in pi['foobar'][0].location)
+        # the second link should be the external one
+        self.assert_('bad_md5' in pi['foobar'][1].location)
+
+
+