Commit 53e5575e authored by Jason R. Coombs's avatar Jason R. Coombs

When invoking rmtree, ensure the parameter is unicode to avoid errors when the...

When invoking rmtree, ensure the parameter is unicode to avoid errors when the tree contains Unicode filenames. Fixes #704.
parent 127dcab5
......@@ -666,6 +666,9 @@ class easy_install(Command):
finally:
if os.path.exists(tmpdir):
# workaround for http://bugs.python.org/issue24672
if six.PY2:
tmpdir = six.u(tmpdir)
rmtree(tmpdir)
def install_item(self, spec, download, tmpdir, deps, install_needed=False):
......
......@@ -169,10 +169,8 @@ class TestEasyInstallTest:
sdist_zip.close()
return str(sdist)
@pytest.mark.xfail(reason="#709 and #710")
# also
#@pytest.mark.xfail(setuptools.tests.is_ascii,
# reason="https://github.com/pypa/setuptools/issues/706")
@pytest.mark.xfail(setuptools.tests.is_ascii,
reason="https://github.com/pypa/setuptools/issues/706")
def test_unicode_filename_in_sdist(self, sdist_unicode, tmpdir, monkeypatch):
"""
The install command should execute correctly even if
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment