Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
S
setuptools
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Jérome Perrin
setuptools
Commits
fc891f5c
Commit
fc891f5c
authored
Dec 31, 2020
by
Sviatoslav Sydorenko
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Apply noqa C901 comments to overly complex code
parent
c225c4c0
Changes
9
Hide whitespace changes
Inline
Side-by-side
Showing
9 changed files
with
34 additions
and
22 deletions
+34
-22
pkg_resources/__init__.py
pkg_resources/__init__.py
+6
-3
setuptools/command/bdist_egg.py
setuptools/command/bdist_egg.py
+1
-1
setuptools/command/easy_install.py
setuptools/command/easy_install.py
+12
-7
setuptools/command/egg_info.py
setuptools/command/egg_info.py
+1
-1
setuptools/dist.py
setuptools/dist.py
+5
-3
setuptools/installer.py
setuptools/installer.py
+1
-1
setuptools/msvc.py
setuptools/msvc.py
+2
-2
setuptools/package_index.py
setuptools/package_index.py
+5
-3
setuptools/ssl_support.py
setuptools/ssl_support.py
+1
-1
No files found.
pkg_resources/__init__.py
View file @
fc891f5c
...
@@ -696,7 +696,8 @@ class WorkingSet:
...
@@ -696,7 +696,8 @@ class WorkingSet:
keys2.append(dist.key)
keys2.append(dist.key)
self._added_new(dist)
self._added_new(dist)
def resolve(self, requirements, env=None, installer=None,
# FIXME: 'WorkingSet.resolve' is too complex (11)
def resolve(self, requirements, env=None, installer=None, # noqa: C901
replace_conflicting=False, extras=None):
replace_conflicting=False, extras=None):
"""List all distributions needed to (recursively) meet `requirements`
"""List all distributions needed to (recursively) meet `requirements`
...
@@ -1745,7 +1746,8 @@ class ZipProvider(EggProvider):
...
@@ -1745,7 +1746,8 @@ class ZipProvider(EggProvider):
timestamp = time.mktime(date_time)
timestamp = time.mktime(date_time)
return timestamp, size
return timestamp, size
def _extract_resource(self, manager, zip_path):
# FIXME: 'ZipProvider._extract_resource' is too complex (12)
def _extract_resource(self, manager, zip_path): # noqa: C901
if zip_path in self._index():
if zip_path in self._index():
for name in self._index()[zip_path]:
for name in self._index()[zip_path]:
...
@@ -2858,7 +2860,8 @@ class Distribution:
...
@@ -2858,7 +2860,8 @@ class Distribution:
"""Return the EntryPoint object for `group`+`name`, or ``None``"""
"""Return the EntryPoint object for `group`+`name`, or ``None``"""
return
self
.
get_entry_map
(
group
).
get
(
name
)
return
self
.
get_entry_map
(
group
).
get
(
name
)
def
insert_on
(
self
,
path
,
loc
=
None
,
replace
=
False
):
# FIXME: 'Distribution.insert_on' is too complex (13)
def
insert_on
(
self
,
path
,
loc
=
None
,
replace
=
False
):
# noqa: C901
"""Ensure self.location is on path
"""Ensure self.location is on path
If replace=False (default):
If replace=False (default):
...
...
setuptools/command/bdist_egg.py
View file @
fc891f5c
...
@@ -153,7 +153,7 @@ class bdist_egg(Command):
...
@@ -153,7 +153,7 @@ class bdist_egg(Command):
self
.
run_command
(
cmdname
)
self
.
run_command
(
cmdname
)
return
cmd
return
cmd
def
run
(
self
):
def
run
(
self
):
# noqa: C901 # is too complex (14) # FIXME
# Generate metadata first
# Generate metadata first
self
.
run_command
(
"egg_info"
)
self
.
run_command
(
"egg_info"
)
# We run install_lib before install_data, because some data hacks
# We run install_lib before install_data, because some data hacks
...
...
setuptools/command/easy_install.py
View file @
fc891f5c
...
@@ -226,7 +226,7 @@ class easy_install(Command):
...
@@ -226,7 +226,7 @@ class easy_install(Command):
print
(
tmpl
.
format
(
**
locals
()))
print
(
tmpl
.
format
(
**
locals
()))
raise
SystemExit
()
raise
SystemExit
()
def
finalize_options
(
self
):
def
finalize_options
(
self
):
# noqa: C901 # is too complex (25) # FIXME
self
.
version
and
self
.
_render_version
()
self
.
version
and
self
.
_render_version
()
py_version
=
sys
.
version
.
split
()[
0
]
py_version
=
sys
.
version
.
split
()[
0
]
...
@@ -437,7 +437,7 @@ class easy_install(Command):
...
@@ -437,7 +437,7 @@ class easy_install(Command):
def
warn_deprecated_options
(
self
):
def
warn_deprecated_options
(
self
):
pass
pass
def
check_site_dir
(
self
):
def
check_site_dir
(
self
):
# noqa: C901 # is too complex (12) # FIXME
"""Verify that self.install_dir is .pth-capable dir, if needed"""
"""Verify that self.install_dir is .pth-capable dir, if needed"""
instdir
=
normalize_path
(
self
.
install_dir
)
instdir
=
normalize_path
(
self
.
install_dir
)
...
@@ -713,7 +713,10 @@ class easy_install(Command):
...
@@ -713,7 +713,10 @@ class easy_install(Command):
if
getattr
(
self
,
attrname
)
is
None
:
if
getattr
(
self
,
attrname
)
is
None
:
setattr
(
self
,
attrname
,
scheme
[
key
])
setattr
(
self
,
attrname
,
scheme
[
key
])
def
process_distribution
(
self
,
requirement
,
dist
,
deps
=
True
,
*
info
):
# FIXME: 'easy_install.process_distribution' is too complex (12)
def
process_distribution
(
# noqa: C901
self
,
requirement
,
dist
,
deps
=
True
,
*
info
,
):
self
.
update_pth
(
dist
)
self
.
update_pth
(
dist
)
self
.
package_index
.
add
(
dist
)
self
.
package_index
.
add
(
dist
)
if
dist
in
self
.
local_index
[
dist
.
key
]:
if
dist
in
self
.
local_index
[
dist
.
key
]:
...
@@ -894,7 +897,8 @@ class easy_install(Command):
...
@@ -894,7 +897,8 @@ class easy_install(Command):
metadata
=
EggMetadata
(
zipimport
.
zipimporter
(
egg_path
))
metadata
=
EggMetadata
(
zipimport
.
zipimporter
(
egg_path
))
return
Distribution
.
from_filename
(
egg_path
,
metadata
=
metadata
)
return
Distribution
.
from_filename
(
egg_path
,
metadata
=
metadata
)
def
install_egg
(
self
,
egg_path
,
tmpdir
):
# FIXME: 'easy_install.install_egg' is too complex (11)
def
install_egg
(
self
,
egg_path
,
tmpdir
):
# noqa: C901
destination
=
os
.
path
.
join
(
destination
=
os
.
path
.
join
(
self
.
install_dir
,
self
.
install_dir
,
os
.
path
.
basename
(
egg_path
),
os
.
path
.
basename
(
egg_path
),
...
@@ -993,7 +997,8 @@ class easy_install(Command):
...
@@ -993,7 +997,8 @@ class easy_install(Command):
# install the .egg
# install the .egg
return
self
.
install_egg
(
egg_path
,
tmpdir
)
return
self
.
install_egg
(
egg_path
,
tmpdir
)
def
exe_to_egg
(
self
,
dist_filename
,
egg_tmp
):
# FIXME: 'easy_install.exe_to_egg' is too complex (12)
def
exe_to_egg
(
self
,
dist_filename
,
egg_tmp
):
# noqa: C901
"""Extract a bdist_wininst to the directories an egg would use"""
"""Extract a bdist_wininst to the directories an egg would use"""
# Check for .pth file and set up prefix translations
# Check for .pth file and set up prefix translations
prefixes
=
get_exe_prefixes
(
dist_filename
)
prefixes
=
get_exe_prefixes
(
dist_filename
)
...
@@ -1191,7 +1196,7 @@ class easy_install(Command):
...
@@ -1191,7 +1196,7 @@ class easy_install(Command):
cfg_filename
=
os
.
path
.
join
(
base
,
'setup.cfg'
)
cfg_filename
=
os
.
path
.
join
(
base
,
'setup.cfg'
)
setopt
.
edit_config
(
cfg_filename
,
settings
)
setopt
.
edit_config
(
cfg_filename
,
settings
)
def
update_pth
(
self
,
dist
):
def
update_pth
(
self
,
dist
):
# noqa: C901 # is too complex (11) # FIXME
if
self
.
pth_file
is
None
:
if
self
.
pth_file
is
None
:
return
return
...
@@ -1427,7 +1432,7 @@ def get_site_dirs():
...
@@ -1427,7 +1432,7 @@ def get_site_dirs():
return
sitedirs
return
sitedirs
def
expand_paths
(
inputs
):
def
expand_paths
(
inputs
):
# noqa: C901 # is too complex (11) # FIXME
"""Yield sys.path directories that might contain "old-style" packages"""
"""Yield sys.path directories that might contain "old-style" packages"""
seen
=
{}
seen
=
{}
...
...
setuptools/command/egg_info.py
View file @
fc891f5c
...
@@ -32,7 +32,7 @@ from setuptools.extern import packaging
...
@@ -32,7 +32,7 @@ from setuptools.extern import packaging
from
setuptools
import
SetuptoolsDeprecationWarning
from
setuptools
import
SetuptoolsDeprecationWarning
def
translate_pattern
(
glob
):
def
translate_pattern
(
glob
):
# noqa: C901 # is too complex (14) # FIXME
"""
"""
Translate a file path glob like '*.txt' in to a regular expression.
Translate a file path glob like '*.txt' in to a regular expression.
This differs from fnmatch.translate which allows wildcards to match
This differs from fnmatch.translate which allows wildcards to match
...
...
setuptools/dist.py
View file @
fc891f5c
...
@@ -119,7 +119,7 @@ def read_pkg_file(self, file):
...
@@ -119,7 +119,7 @@ def read_pkg_file(self, file):
# Based on Python 3.5 version
# Based on Python 3.5 version
def
write_pkg_file
(
self
,
file
):
def
write_pkg_file
(
self
,
file
):
# noqa: C901 # is too complex (14) # FIXME
"""Write the PKG-INFO format data to a file object.
"""Write the PKG-INFO format data to a file object.
"""
"""
version
=
self
.
get_metadata_version
()
version
=
self
.
get_metadata_version
()
...
@@ -548,7 +548,8 @@ class Distribution(_Distribution):
...
@@ -548,7 +548,8 @@ class Distribution(_Distribution):
req
.
marker
=
None
req
.
marker
=
None
return
req
return
req
def
_parse_config_files
(
self
,
filenames
=
None
):
# FIXME: 'Distribution._parse_config_files' is too complex (14)
def
_parse_config_files
(
self
,
filenames
=
None
):
# noqa: C901
"""
"""
Adapted from distutils.dist.Distribution.parse_config_files,
Adapted from distutils.dist.Distribution.parse_config_files,
this method provides the same functionality in subtly-improved
this method provides the same functionality in subtly-improved
...
@@ -612,7 +613,8 @@ class Distribution(_Distribution):
...
@@ -612,7 +613,8 @@ class Distribution(_Distribution):
except
ValueError
as
e
:
except
ValueError
as
e
:
raise
DistutilsOptionError
(
e
)
from
e
raise
DistutilsOptionError
(
e
)
from
e
def
_set_command_options
(
self
,
command_obj
,
option_dict
=
None
):
# FIXME: 'Distribution._set_command_options' is too complex (14)
def
_set_command_options
(
self
,
command_obj
,
option_dict
=
None
):
# noqa: C901
"""
"""
Set the options for 'command_obj' from 'option_dict'. Basically
Set the options for 'command_obj' from 'option_dict'. Basically
this means copying elements of a dictionary ('option_dict') to
this means copying elements of a dictionary ('option_dict') to
...
...
setuptools/installer.py
View file @
fc891f5c
...
@@ -51,7 +51,7 @@ def _legacy_fetch_build_egg(dist, req):
...
@@ -51,7 +51,7 @@ def _legacy_fetch_build_egg(dist, req):
return
cmd
.
easy_install
(
req
)
return
cmd
.
easy_install
(
req
)
def
fetch_build_egg
(
dist
,
req
):
def
fetch_build_egg
(
dist
,
req
):
# noqa: C901 # is too complex (16) # FIXME
"""Fetch an egg needed for building.
"""Fetch an egg needed for building.
Use pip/wheel to fetch/build a wheel."""
Use pip/wheel to fetch/build a wheel."""
...
...
setuptools/msvc.py
View file @
fc891f5c
...
@@ -921,8 +921,8 @@ class SystemInfo:
...
@@ -921,8 +921,8 @@ class SystemInfo:
"""
"""
return self._use_last_dir_name(join(self.WindowsSdkDir, '
lib
'))
return self._use_last_dir_name(join(self.WindowsSdkDir, '
lib
'))
@property
@property
# noqa: C901
def WindowsSdkDir(self):
def WindowsSdkDir(self):
# noqa: C901 # is too complex (12) # FIXME
"""
"""
Microsoft Windows SDK directory.
Microsoft Windows SDK directory.
...
...
setuptools/package_index.py
View file @
fc891f5c
...
@@ -320,7 +320,8 @@ class PackageIndex(Environment):
...
@@ -320,7 +320,8 @@ class PackageIndex(Environment):
else:
else:
self.opener = urllib.request.urlopen
self.opener = urllib.request.urlopen
def process_url(self, url, retrieve=False):
# FIXME: 'PackageIndex.process_url' is too complex (14)
def process_url(self, url, retrieve=False): # noqa: C901
"""
Evaluate
a
URL
as
a
possible
download
,
and
maybe
retrieve
it
"""
"""
Evaluate
a
URL
as
a
possible
download
,
and
maybe
retrieve
it
"""
if url in self.scanned_urls and not retrieve:
if url in self.scanned_urls and not retrieve:
return
return
...
@@ -595,7 +596,7 @@ class PackageIndex(Environment):
...
@@ -595,7 +596,7 @@ class PackageIndex(Environment):
spec = parse_requirement_arg(spec)
spec = parse_requirement_arg(spec)
return getattr(self.fetch_distribution(spec, tmpdir), 'location', None)
return getattr(self.fetch_distribution(spec, tmpdir), 'location', None)
def fetch_distribution(
def fetch_distribution(
# noqa: C901 # is too complex (14) # FIXME
self, requirement, tmpdir, force_scan=False, source=False,
self, requirement, tmpdir, force_scan=False, source=False,
develop_ok=False, local_index=None):
develop_ok=False, local_index=None):
"""
Obtain
a
distribution
suitable
for
fulfilling
`requirement`
"""
Obtain
a
distribution
suitable
for
fulfilling
`requirement`
...
@@ -766,7 +767,8 @@ class PackageIndex(Environment):
...
@@ -766,7 +767,8 @@ class PackageIndex(Environment):
def reporthook(self, url, filename, blocknum, blksize, size):
def reporthook(self, url, filename, blocknum, blksize, size):
pass # no-op
pass # no-op
def open_url(self, url, warning=None):
# FIXME:
def open_url(self, url, warning=None): # noqa: C901 # is too complex (12)
if url.startswith('file:'):
if url.startswith('file:'):
return local_open(url)
return local_open(url)
try:
try:
...
...
setuptools/ssl_support.py
View file @
fc891f5c
...
@@ -56,7 +56,7 @@ if not CertificateError:
...
@@ -56,7 +56,7 @@ if not CertificateError:
pass
pass
if
not
match_hostname
:
if
not
match_hostname
:
# noqa: C901 # 'If 59' is too complex (21) # FIXME
def
_dnsname_match
(
dn
,
hostname
,
max_wildcards
=
1
):
def
_dnsname_match
(
dn
,
hostname
,
max_wildcards
=
1
):
"""Matching according to RFC 6125, section 6.4.3
"""Matching according to RFC 6125, section 6.4.3
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment