- 11 Jul, 2019 4 commits
-
-
Vincent Pelletier authored
This property is only conditionally set, which causes distracting error when something goes wrong. If we really want to check that the expected code path was followed there has to be a better check and a more debugging- friendly error than an AttributeError.
-
Vincent Pelletier authored
While it does not make sense, it is possible to spawn activities with a group_id set but without a grouping_metohd_id. This is for example easy to trigger using recurseCallMethod from ERP5Type.Core.Folder: the _recurseCallMethod activity spawned nullifies grouping_method_id but does not (currently) clean group_id, leading to inconsistency between how "non-groupped" conditions are evaluated in getProcessableMessageList and dequeueMessage. The consequence is zombie activities: they never fail, do not prevent other activities from being executed, but and are permanently run on the node which reserved more than one because: - all but one activity is in MESSAGE_NOT_EXECUTED state, forcing an abort - finalizeMessageExecution does not understand that MESSAGE_NOT_EXECUTED activities may not have failed, and itself fail while trying to detect the failure type (ConflictError vs. others), failing to free & postpone the activity, in turn failing to bring it to eventually permanent failure state. Make those conditions consistent, and use tuple-unpacking to detect any future inconsistency much earlier, simplifying debugging.
-
Vincent Pelletier authored
group_method_id column is declared "NOT NULL", so it can only be None if getProcessableMessageList could not find any activity, in which case this code is not executed ("if message_list" is false). This simplifies two "if" statements.
-
Vincent Pelletier authored
Unsure whether this makes a difference, but let's be on the safe side.
-
- 10 Jul, 2019 1 commit
-
-
Arnaud Fontaine authored
* Not updated for many years (CodeMirror has since replaced it). * There are now 2 other better source code editors (CodeMirror and Monaco).
-
- 09 Jul, 2019 1 commit
-
-
Valentin Benozillo authored
-
- 08 Jul, 2019 2 commits
-
-
Romain Courteaud authored
Base domain .getRelativeUrl method does not include portal_domains. See https://lab.nexedi.com/nexedi/erp5/blob/c3f0585cc1ddb888d356b3395b947b90cb188356/product/ERP5/Document/Domain.py#L91
-
Romain Courteaud authored
-
- 05 Jul, 2019 2 commits
-
-
Romain Courteaud authored
See nexedi/erp5@88f24700 and nexedi/erp5@796c3520
-
Nicolas Wavrant authored
-
- 04 Jul, 2019 9 commits
-
-
Valentin Benozillo authored
-
Romain Courteaud authored
-
Romain Courteaud authored
Clone Base_doAction to keep the logic identical. Reuse Folder_create directly to reduce difference from xhtml_style. Side effect: the status message is modified from 'Document created.' to 'Object created.'
-
Romain Courteaud authored
-
Roque authored
-
Jérome Perrin authored
This works only for medusa, using the same approach as CMFCore's CookieCrumbler Also increase test coverage of google/facebook plugins. /reviewed-on nexedi/erp5!901
-
Jérome Perrin authored
What I'm trying to prevent, is that when we have a document with leading/trailing space ![image](/uploads/8a00a1019cdcb5d76bd589917548a515/image.png) and it's set in a relation ![image](/uploads/925aa9895c7d15f3ef9f3bdc9926d7fd/image.png) just clicking save will complain that document is not found ![image](/uploads/a559eea23fc8ba0df19c23dfcda26138/image.png) this is because validator have stripped whitespace and search for `"leading and trailing space"` - and find nothing (unless title is a keyword key, but that's another story ) /reviewed-on nexedi/erp5!897
-
Sebastien Robin authored
Until know, in the preference we defined list of uri for conversion server, and then we were trying always in the order defined in the preference. But this is not optimal, when a server start to fail, it's better to try using another one. So sort list of uri in such a way to use first server having the most chance to work.
-
Arnaud Fontaine authored
Useful for SolverType._configuration_property_dict but more generally the whole history should be displayed as this view is used by developers.
-
- 02 Jul, 2019 1 commit
-
-
Georgios Dagkakis authored
erp5_web_renderjs_ui: Don't crash if form has 'Update Action Title' but no 'Form update action' defined. Even though this is inconsistent form definition, form_dialog gadget should not crash
-
- 01 Jul, 2019 8 commits
-
-
Sebastien Robin authored
in MRP, we have manufacturing execution having a mix of lines with positive and negative values. It must be possible to use split and defer solver in that case.
-
Georgios Dagkakis authored
For example, Categories in "expired" state. As a consequence, user is included in cache key. /reviewed-on nexedi/erp5!899
-
Romain Courteaud authored
-
Jérome Perrin authored
This works only for medusa, using the same approach as CMFCore's CookieCrumbler
-
Jérome Perrin authored
-
Jérome Perrin authored
-
Jérome Perrin authored
-
Jérome Perrin authored
-
- 28 Jun, 2019 3 commits
-
-
Julien Muchembled authored
-
Bryton Lacquement authored
-
Jérome Perrin authored
This function have evolved to something very trivial not accessing anything from database, so caching this no longer really makes sense, also the cache keys are really big. On a quick benchmark of calling ERP5Site_getTabList 10000 times: with cache: ERP5Site_getTabList took 12.961781 without cache: ERP5Site_getTabList took 5.395873
-
- 27 Jun, 2019 6 commits
-
-
Romain Courteaud authored
Only send line data if the text is not empty and ensure there is no hole in the uid list. This will fix the edition when the field already contains some homonyms. Only append empty input if the latest one is not empty. Replace verify by assert in the tests.
-
Romain Courteaud authored
Fixup nexedi/erp5@18415f4d
-
Sebastien Robin authored
When we ignore variations, we should also ignore them when looking to update existing orders
-
Julien Muchembled authored
erp5_web_manifest_test:testManifest leave a -1 activity.
-
Bryton Lacquement authored
W3Validator seems obsolete now since it does not validate HTML5. nu became the default validator in 417ff1ae. /reviewed-on nexedi/erp5!786
-
Jérome Perrin authored
Add some tests and fix bugs: * https://nexedi.erp5.net/bug_module/20170426-A3962E * another bug that columns names were not escaped ( in a project we have a custom table with a column named `use` and this breaks `upgradeSchema` ) /reviewed-on nexedi/erp5!854
-
- 26 Jun, 2019 3 commits
-
-
Sebastien Robin authored
-
Jérome Perrin authored
Note that we can't really use " " in test tables, for input selenium supports ${space} magic that types a space characters, but to check the values, we cannot just use assertValue which strips the leading/trailing spaces, so we use a custom assertEval expression.
-
Jérome Perrin authored
We want to search for what user entered, if we strip whitespaces we would not match trailing or leading spaces
-