1. 11 Jul, 2019 3 commits
    • Vincent Pelletier's avatar
      CMFActivity.Activity.SQLBase: Tolerate group_id set without a grouping_method_id. · ef313964
      Vincent Pelletier authored
      While it does not make sense, it is possible to spawn activities with a
      group_id set but without a grouping_metohd_id. This is for example easy to
      trigger using recurseCallMethod from ERP5Type.Core.Folder: the
      _recurseCallMethod activity spawned nullifies grouping_method_id but does
      not (currently) clean group_id, leading to inconsistency between how
      "non-groupped" conditions are evaluated in getProcessableMessageList and
      dequeueMessage.
      The consequence is zombie activities: they never fail, do not prevent other
      activities from being executed, but and are permanently run on the node
      which reserved more than one because:
      - all but one activity is in MESSAGE_NOT_EXECUTED state, forcing an abort
      - finalizeMessageExecution does not understand that MESSAGE_NOT_EXECUTED
        activities may not have failed, and itself fail while trying to detect
        the failure type (ConflictError vs. others), failing to free & postpone
        the activity, in turn failing to bring it to eventually permanent failure
        state.
      Make those conditions consistent, and use tuple-unpacking to detect any
      future inconsistency much earlier, simplifying debugging.
      ef313964
    • Vincent Pelletier's avatar
      CMFActivity.Activity.SQLBase: Expect group_method_id to always be a string. · 8777cc47
      Vincent Pelletier authored
      group_method_id column is declared "NOT NULL", so it can only be None if
      getProcessableMessageList could not find any activity, in which case this
      code is not executed ("if message_list" is false).
      This simplifies two "if" statements.
      8777cc47
    • Vincent Pelletier's avatar
      CMFActivity.Activity.SQLBase: Avoid reference loops. · 19e651d4
      Vincent Pelletier authored
      Unsure whether this makes a difference, but let's be on the safe side.
      19e651d4
  2. 10 Jul, 2019 1 commit
    • Arnaud Fontaine's avatar
      erp5_ace_editor: Removed. · 94a179a6
      Arnaud Fontaine authored
      * Not updated for many years (CodeMirror has since replaced it).
      * There are now 2 other better source code editors (CodeMirror and Monaco).
      94a179a6
  3. 09 Jul, 2019 1 commit
  4. 08 Jul, 2019 2 commits
  5. 05 Jul, 2019 2 commits
  6. 04 Jul, 2019 9 commits
  7. 02 Jul, 2019 1 commit
  8. 01 Jul, 2019 8 commits
  9. 28 Jun, 2019 3 commits
  10. 27 Jun, 2019 6 commits
  11. 26 Jun, 2019 3 commits
  12. 25 Jun, 2019 1 commit