.

wcfs/client/wcfs.cpp

@@ -969,7 +969,7 @@ error _Mapping::unmap() {
 //
 // The following locks must be held by caller:
 // - f.wconn.atMu
-// - f._mu
+// - f._mu          XXX not needed? (f._mmaps and f._pinned are not used)
 error _Mapping::_remmapblk(int64_t blk, zodb::Tid at) {
     _Mapping *mmap = this;
     FileH f = mmap->fileh;
@@ -1030,7 +1030,6 @@ error _Mapping::remmap_blk(int64_t blk) {
     FileH f = mmap.fileh;
 
     // NOTE virtmem lock is held by virtmem caller
-    // XXX locking ok?
     f->wconn->_atMu.RLock();
     f->_mu.lock();
     defer([&]() {

wcfs/client/wcfs.h

@@ -271,6 +271,7 @@ public:
 // Use .unmap to release virtual memory resources used by mapping.
 //
 // Except unmap, it is safe to use Mapping from multiple threads simultaneously.
+// XXX unmap wrt remmapblk? -> crash? or protect?
 typedef refptr<struct _Mapping> Mapping;
 struct _Mapping : object {
     FileH   fileh;