.

bigfile/_file_zodb.pyx

@@ -96,7 +96,7 @@ cdef public class _ZBigFile(BigFile) [object _ZBigFile, type _ZBigFile_Type]:
 
 # functions that we give to virtmem bigfile_ops .mmap*
 cdef extern from * nogil:
-    pass
+    const bigfile_ops ZBigFile_mmap_ops
 
 
 

bigfile/file_zodb.cpp

@@ -18,6 +18,7 @@
 // See https://www.nexedi.com/licensing for rationale and options.
 
 // File file_zodb.cpp provides blkmmapper functions for _ZBigFile.
+// MMapping is implemented via WCFS.
 
 #include "wcfs/internal/wcfs.h"
 #include "wendelin/bigfile/file.h"
@@ -25,7 +26,7 @@
 #include "bigfile/_bigfile.h"
 #include "bigfile/_file_zodb.h"
 
-void* zfile_mmap_setup_read(VMA *vma, BigFile *file, blk_t blk, size_t blklen) {
+static void* zfile_mmap_setup_read(VMA *vma, BigFile *file, blk_t blk, size_t blklen) {
     //_ZBigFile* _zfile = static_cast<_ZBigFile*>(file);
     _ZBigFile* _zfile = NULL;   // XXX
 
@@ -47,7 +48,7 @@ void* zfile_mmap_setup_read(VMA *vma, BigFile *file, blk_t blk, size_t blklen) {
     return (void*)vma->addr_start;  // XXX kill if we set vma->addr_*
 }
 
-int zfile_remmap_blk_read(VMA *vma, BigFile *file, blk_t blk) {
+static int zfile_remmap_blk_read(VMA *vma, BigFile *file, blk_t blk) {
     wcfs::_Mapping *mmap = static_cast<wcfs::_Mapping*>(vma->mmap_overlay_server);
     // XXX use file?
 
@@ -56,7 +57,7 @@ int zfile_remmap_blk_read(VMA *vma, BigFile *file, blk_t blk) {
 }
 
 
-void zfile_munmap(VMA *vma, BigFile *file) {
+static void zfile_munmap(VMA *vma, BigFile *file) {
     // NOTE taking 1 ref back from vma->mmap_overlay_server
     wcfs::Mapping mmap = adoptref(static_cast<wcfs::_Mapping*>(vma->mmap_overlay_server));
     vma->mmap_overlay_server = NULL;
@@ -68,7 +69,7 @@ void zfile_munmap(VMA *vma, BigFile *file) {
 
 
 //const VirtMMapper zfile_mmapper = {
-const bigfile_ops zfile_mmap_ops = {
+const bigfile_ops ZBigFile_mmap_ops = {
     .mmap_setup_read    = zfile_mmap_setup_read,
     .remmap_blk_read    = zfile_remmap_blk_read,
     .munmap             = zfile_munmap,