Since the Unix and Windows tests share a common infrastructure now,

rename UnixConnectionTests to FileStorageConnectionTests, and add a
simple BDBConnectionTests class to use Berkeley Full storage.

WindowsConnectionTests: Removed.

src/ZEO/tests/testConnection.py

@@ -18,23 +18,13 @@ platform-dependent scaffolding.
 """
 
 # System imports
-import os
-import time
-import socket
 import unittest
-
-# Zope/ZODB3 imports
-import zLOG
-
-# ZEO test support
-from ZEO.tests import forker
-
 # Import the actual test class
 from ZEO.tests.ConnectionTests import ConnectionTests
 
-class UnixConnectionTests(ConnectionTests):
 
-    """Add Unix-specific scaffolding to the generic test suite."""
+class FileStorageConnectionTests(ConnectionTests):
+    """Add FileStorage-specific test."""
 
     def getConfig(self, path, create, read_only):
         return """\
@@ -47,29 +37,10 @@ class UnixConnectionTests(ConnectionTests):
                          create and 'yes' or 'no',
                          read_only and 'yes' or 'no')
 
-    def startServer(self, create=1, index=0, read_only=0, ro_svr=0):
-        zLOG.LOG("testZEO", zLOG.INFO,
-                 "startServer(create=%d, index=%d, read_only=%d)" %
-                 (create, index, read_only))
-        path = "%s.%d" % (self.file, index)
-        addr = self.addr[index]
-        conf = self.getConfig(path, create, read_only)
-        pid, server = forker.start_zeo_server(conf, addr, ro_svr)
-        self._pids.append(pid)
-        self._servers.append(server)
 
-    def shutdownServer(self, index=0):
-        zLOG.LOG("testZEO", zLOG.INFO, "shutdownServer(index=%d)" % index)
-        self._servers[index].close()
-        if self._pids[index] is not None:
-            try:
-                os.waitpid(self._pids[index], 0)
-                self._pids[index] = None
-            except os.error, err:
-                print err
+class BDBConnectionTests(FileStorageConnectionTests):
+    """Berkeley storage tests."""
 
-
-class BDBConnectionTests(UnixConnectionTests):
     def getConfig(self, path, create, read_only):
         # Full always creates and doesn't have a read_only flag
         return """\
@@ -80,40 +51,7 @@ class BDBConnectionTests(UnixConnectionTests):
         </Storage>""" % (path, read_only)
 
 
-class WindowsConnectionTests(ConnectionTests):
-
-    """Add Windows-specific scaffolding to the generic test suite."""
-
-    def startServer(self, create=1, index=0, read_only=0, ro_svr=0):
-        zLOG.LOG("testZEO", zLOG.INFO,
-                 "startServer(create=%d, index=%d, read_only=%d)" %
-                 (create, index, read_only))
-        path = "%s.%d" % (self.file, index)
-        addr = self.addr[index]
-        args = (path, '='+str(create), '='+str(read_only))
-        _addr, test_addr, test_pid = forker.start_zeo_server(
-            'FileStorage', args, addr, ro_svr)
-        self._pids.append(test_pid)
-        self._servers.append(test_addr)
-
-    def shutdownServer(self, index=0):
-        zLOG.LOG("testZEO", zLOG.INFO, "shutdownServer(index=%d)" % index)
-        if self._servers[index] is not None:
-            s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
-            s.connect(self._servers[index])
-            s.close()
-            self._servers[index] = None
-            # XXX waitpid() isn't available until Python 2.3
-            time.sleep(0.5)
-
-
-if os.name == "posix":
-    test_classes = [UnixConnectionTests]
-elif os.name == "nt":
-    test_classes = [WindowsConnectionTests]
-else:
-    raise RuntimeError, "unsupported os: %s" % os.name
-
+test_classes = [FileStorageConnectionTests]
 try:
     from bsddb3Storage.Full import Full
 except ImportError:
@@ -133,5 +71,6 @@ def test_suite():
         suite.addTest(sub)
     return suite
 
+
 if __name__ == "__main__":
     unittest.main(defaultTest='test_suite')