Commit 21191318 authored by Dmitriy Zaporozhets's avatar Dmitriy Zaporozhets

refactor wall.js. style wall page a bit

parent 583bfac5
...@@ -58,14 +58,26 @@ ...@@ -58,14 +58,26 @@
form.show() form.show()
renderNote: (note) -> renderNote: (note) ->
author = '<strong class="wall-author">' + note.author.name + '</strong>' template = Wall.noteTemplate()
body = '<span class="wall-text">' + linkify(sanitize(note.body)) + '</span>' template = template.replace('{{author_name}}', note.author.name)
file = '' template = template.replace('{{created_at}}', note.created_at)
time = '<abbr class="timeago" title="' + note.created_at + '">' + note.created_at + '</time>' template = template.replace('{{text}}', linkify(sanitize(note.body)))
if note.attachment if note.attachment
file = '<span class="wall-file"><a href="/files/note/' + note.id + '/' + note.attachment + '">' + note.attachment + '</a></span>' file = '<i class="icon-paper-clip"/><a href="/files/note/' + note.id + '/' + note.attachment + '">' + note.attachment + '</a>'
else
html = '<li>' + author + body + file + time + '</li>' file = ''
template = template.replace('{{file}}', file)
$('ul.notes').append(template)
$('ul.notes').append(html) noteTemplate: ->
return '<li>
<strong class="wall-author">{{author_name}}</strong>
<span class="wall-text">
{{text}}
<span class="wall-file">{{file}}</span>
</span>
<abbr class="timeago" title="{{created_at}}">{{created_at}}</abbr>
</li>'
...@@ -14,12 +14,28 @@ ...@@ -14,12 +14,28 @@
.notes { .notes {
margin-bottom: 160px; margin-bottom: 160px;
background: #FFE;
border: 1px solid #EED;
> li {
@extend .clearfix;
border-bottom: 1px solid #EED;
padding: 10px;
}
.wall-author { .wall-author {
color: #666; color: #666;
margin-right: 10px; float: left;
border-right: 1px solid #CCC; width: 100px;
padding-right: 5px text-overflow: ellipsis;
}
.wall-text {
border-left: 1px solid #CCC;
margin-left: 10px;
padding-left: 10px;
float: left;
width: 80%;
} }
.wall-file { .wall-file {
......
%div.wall-page %div.wall-page
%ul.well-list.notes %ul.notes
- if can? current_user, :write_note, @project - if can? current_user, :write_note, @project
.note-form-holder .note-form-holder
......
...@@ -21,11 +21,6 @@ describe "On a merge request", js: true do ...@@ -21,11 +21,6 @@ describe "On a merge request", js: true do
it { find(".js-main-target-form input[type=submit]").value.should == "Add Comment" } it { find(".js-main-target-form input[type=submit]").value.should == "Add Comment" }
it { within(".js-main-target-form") { should_not have_link("Cancel") } } it { within(".js-main-target-form") { should_not have_link("Cancel") } }
# notifiactions
it { within(".js-main-target-form") { should have_unchecked_field("Notify team via email") } }
it { within(".js-main-target-form") { should_not have_checked_field("Notify commit author") } }
it { within(".js-main-target-form") { should_not have_unchecked_field("Notify commit author") } }
describe "without text" do describe "without text" do
it { within(".js-main-target-form") { should have_css(".js-note-preview-button", visible: false) } } it { within(".js-main-target-form") { should have_css(".js-note-preview-button", visible: false) } }
end end
...@@ -126,9 +121,6 @@ describe "On a merge request diff", js: true, focus: true do ...@@ -126,9 +121,6 @@ describe "On a merge request diff", js: true, focus: true do
it { should have_button("Add Comment") } it { should have_button("Add Comment") }
it { should have_css(".js-close-discussion-note-form", text: "Cancel") } it { should have_css(".js-close-discussion-note-form", text: "Cancel") }
# notification options
it { should have_unchecked_field("Notify team via email") }
it "shouldn't add a second form for same row" do it "shouldn't add a second form for same row" do
find("#4735dfc552ad7bf15ca468adc3cad9d05b624490_185_185.line_holder .js-add-diff-note-button").trigger("click") find("#4735dfc552ad7bf15ca468adc3cad9d05b624490_185_185.line_holder .js-add-diff-note-button").trigger("click")
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment