Commit 3b7f3428 authored by Tomasz Maczukin's avatar Tomasz Maczukin

Modify :ci_variable factory

parent d3380876
...@@ -16,10 +16,7 @@ ...@@ -16,10 +16,7 @@
FactoryGirl.define do FactoryGirl.define do
factory :ci_variable, class: Ci::Variable do factory :ci_variable, class: Ci::Variable do
id 10 sequence(:key) { |n| "VARIABLE_#{n}" }
key 'TEST_VARIABLE_1' value 'VARIABLE_VALUE'
value 'VALUE_1'
project factory: :empty_project
end end
end end
...@@ -46,7 +46,7 @@ describe API::API, api: true do ...@@ -46,7 +46,7 @@ describe API::API, api: true do
expect(json_response['value']).to eq(variable.value) expect(json_response['value']).to eq(variable.value)
end end
it 'should responde with 404 Not Found if requesting non-existing variable' do it 'should respond with 404 Not Found if requesting non-existing variable' do
get api("/projects/#{project.id}/variables/non_existing_variable", user) get api("/projects/#{project.id}/variables/non_existing_variable", user)
expect(response.status).to eq(404) expect(response.status).to eq(404)
...@@ -84,7 +84,7 @@ describe API::API, api: true do ...@@ -84,7 +84,7 @@ describe API::API, api: true do
it 'should not allow to duplicate variable key' do it 'should not allow to duplicate variable key' do
expect do expect do
post api("/projects/#{project.id}/variables", user), key: 'TEST_VARIABLE_1', value: 'VALUE_2' post api("/projects/#{project.id}/variables", user), key: variable.key, value: 'VALUE_2'
end.to change{project.variables.count}.by(0) end.to change{project.variables.count}.by(0)
expect(response.status).to eq(400) expect(response.status).to eq(400)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment