Commit 6fafe000 authored by Dmitriy Zaporozhets's avatar Dmitriy Zaporozhets

Merge branch 'prevent-duobling-ready-events' into 'master'

Prevent unnecessary doubling of js events on import pages and user calendar

Adding document.ready in Turbolinks make duplicating of events EVERY visit of page.
In example of user calendar it causes N+1 times ajax request every time you visit user page.

cc @vsizov

See merge request !456
parents 12430b65 a1d09190
...@@ -42,6 +42,7 @@ v 7.10.0 (unreleased) ...@@ -42,6 +42,7 @@ v 7.10.0 (unreleased)
- Send EmailsOnPush email when branch or tag is created or deleted. - Send EmailsOnPush email when branch or tag is created or deleted.
- Faster merge request processing for large repository - Faster merge request processing for large repository
- Prevent doubling AJAX request with each commit visit via Turbolink - Prevent doubling AJAX request with each commit visit via Turbolink
- Prevent unnecessary doubling of js events on import pages and user calendar
v 7.9.0 v 7.9.0
- Add HipChat integration documentation (Stan Hu) - Add HipChat integration documentation (Stan Hu)
......
...@@ -42,5 +42,4 @@ ...@@ -42,5 +42,4 @@
= button_tag "Import", class: "btn js-add-to-import" = button_tag "Import", class: "btn js-add-to-import"
:coffeescript :coffeescript
$ -> new ImporterStatus("#{jobs_import_bitbucket_path}", "#{import_bitbucket_path}")
new ImporterStatus("#{jobs_import_bitbucket_path}", "#{import_bitbucket_path}")
...@@ -42,5 +42,4 @@ ...@@ -42,5 +42,4 @@
= button_tag "Import", class: "btn js-add-to-import" = button_tag "Import", class: "btn js-add-to-import"
:coffeescript :coffeescript
$ -> new ImporterStatus("#{jobs_import_github_path}", "#{import_github_path}")
new ImporterStatus("#{jobs_import_github_path}", "#{import_github_path}")
...@@ -42,5 +42,4 @@ ...@@ -42,5 +42,4 @@
= button_tag "Import", class: "btn js-add-to-import" = button_tag "Import", class: "btn js-add-to-import"
:coffeescript :coffeescript
$ -> new ImporterStatus("#{jobs_import_gitlab_path}", "#{import_gitlab_path}")
new ImporterStatus("#{jobs_import_gitlab_path}", "#{import_gitlab_path}")
...@@ -42,5 +42,4 @@ ...@@ -42,5 +42,4 @@
= button_tag "Import", class: "btn js-add-to-import" = button_tag "Import", class: "btn js-add-to-import"
:coffeescript :coffeescript
$ -> new ImporterStatus("#{jobs_import_gitorious_path}", "#{import_gitorious_path}")
new ImporterStatus("#{jobs_import_gitorious_path}", "#{import_gitorious_path}")
...@@ -43,7 +43,6 @@ ...@@ -43,7 +43,6 @@
You're receiving notifications because you're subscribed to this thread. You're receiving notifications because you're subscribed to this thread.
:coffeescript :coffeescript
$ -> new Subscription("#{toggle_subscription_namespace_project_issue_path(@issue.project.namespace, @project, @issue)}")
new Subscription("#{toggle_subscription_namespace_project_issue_path(@issue.project.namespace, @project, @issue)}")
...@@ -45,7 +45,4 @@ ...@@ -45,7 +45,4 @@
You're receiving notifications because you're subscribed to this thread. You're receiving notifications because you're subscribed to this thread.
:coffeescript :coffeescript
$ -> new Subscription("#{toggle_subscription_namespace_project_merge_request_path(@merge_request.project.namespace, @project, @merge_request)}")
new Subscription("#{toggle_subscription_namespace_project_merge_request_path(@merge_request.project.namespace, @project, @merge_request)}")
\ No newline at end of file
...@@ -109,9 +109,8 @@ ...@@ -109,9 +109,8 @@
%p Please wait a moment, this page will automatically refresh when ready. %p Please wait a moment, this page will automatically refresh when ready.
:coffeescript :coffeescript
$ -> $('.how_to_import_link').bind 'click', (e) ->
$('.how_to_import_link').bind 'click', (e) -> e.preventDefault()
e.preventDefault() import_modal = $(this).next(".modal").show()
import_modal = $(this).next(".modal").show() $('.modal-header .close').bind 'click', ->
$('.modal-header .close').bind 'click', -> $(".modal").hide()
$(".modal").hide()
...@@ -47,5 +47,4 @@ ...@@ -47,5 +47,4 @@
= render 'projects' = render 'projects'
:coffeescript :coffeescript
$ -> $(".user-calendar").load("#{user_calendar_path}")
$(".user-calendar").load("#{user_calendar_path}")
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment