Commit da8e0f86 authored by Dmitriy Zaporozhets's avatar Dmitriy Zaporozhets

Merge branch 'take-guidelines-into-account-for-mrs' into 'master'

Link to Thoughtbot review guidelines.



See merge request !2658
parents 48eb2cd6 7d985631
...@@ -255,6 +255,8 @@ For examples of feedback on merge requests please look at already ...@@ -255,6 +255,8 @@ For examples of feedback on merge requests please look at already
request feel free to mention one of the Merge Marshalls of the [core team][]. request feel free to mention one of the Merge Marshalls of the [core team][].
Please ensure that your merge request meets the contribution acceptance criteria. Please ensure that your merge request meets the contribution acceptance criteria.
When having your code reviewed and when reviewing merge requests please take the [thoughtbot code review guidelines](https://github.com/thoughtbot/guides/tree/master/code-review) into account.
## Definition of done ## Definition of done
If you contribute to GitLab please know that changes involve more than just If you contribute to GitLab please know that changes involve more than just
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment