Improve personal snippet access workflow.

Replaces !1709

Fixes #3258

See merge request !1817

Add option to create merge request when editing/creating a file

Replaces !1611 

Fixes #3059

See merge request !1820

Fix 'Attach a file' link in new tag form

Also removed a little bit of code repetition :)

See merge request !1834

Update gitlab-shell documentation to 2.6.7



See merge request !1836

Do not limit workhorse POST/PUT size in NGINX

Limiting, if any, should happen in gitlab-workhorse.

See merge request !1831

Add link to git-lfs client  [ci skip]



See merge request !1832

Fix bottom position of scroll buttons in build log page

Look at the up/down buttons as well as the **Enable Autoscroll**.

The **Enable Autoscroll** could also be alligned with the right grey box.


## Before

![autoscroll_before](/uploads/f410dc353ca66c338d8a29c7c294758a/autoscroll_before.png)

## After

![autoscroll_after](/uploads/015fdf53618a0d6f468d666de1bbab6a/autoscroll_after.png)


\cc @dzaporozhets @creamzy 

See merge request !1792

Limiting, if any, should happen in gitlab-workhorse.

Deploy page should be shown for all pages not just root

Related to change already merged to Omnibus - gitlab-org/omnibus-gitlab!540

This change makes it so the deploy page is shown on all GitLab pages if the page exists. Users will no longer receive the 502 when deploys are happening.

See merge request !1828

Improve performance of user profiles, finding groups, and finding projects

This MR improves the following:

* Rendering of profile pages and Atom feeds
* Finding groups (using GroupsFinder & friends)
* Finding projects (using ProjectsFinder & friends)

Initially this MR was intended to only improve rendering of Atom feeds, but over time other fixes were introduced as well as the same code was the cause of all these problems.

See merge request !1790

Check which folders and archives should be packed before passing to tar command.

If user uses backup task with SKIP and skips one of the archives listed(uploads, builds, artifacts) backup create will give an error: `Cannot stat: No such file or directory`.

This MR fixes that by checking for skipped items.
Additionally, compact everything to avoid `TypeError: no implicit conversion of nil into String` errors.

See merge request !1824

Fix huge line height for diff files list
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

See merge request !1826

Backport relevant changes from gitlab-org/gitlab-ee!51

To do:

- [x] Update gitlab-shell

See merge request !1822

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

When getting the projects of a user we should get the public _and_
internal projects, not just the public ones.

Apparently MySQL doesn't support this syntax:

    (...) UNION (...)

instead it only supports:

    ...
    UNION
    ...

This won't work efficiently if you happen to have a lot of projects.

These changes are based on those from commit
03f5ff75, except they use a UNION
instead of plucking IDs into memory.

Previously this controller would in multiple places load tons (read:
around 65000) project and/or group IDs into memory. These changes in
combination with the previous commits significantly cut down loading
times of user profile pages and the Atom feeds of users.

These methods no longer include public groups/projects (that don't
belong to the actual user) as this is handled by the various finder
classes now. This also removes the need for passing extra arguments.

Note that memoizing was removed _explicitly_. For whatever reason doing
so messes up the users controller to a point where it claims a certain
user does _not_ have access to certain groups/projects when it does have
access. Existing code shouldn't be affected as these methods are only
called in ways that they'd run queries anyway (e.g. a combination of
"any?" and "each" which would run 2 queries regardless of memoizing).

This method can be used to filter projects to those visible to a given
user.

These methods will be used to get a list of groups, optionally
restricted to only those visible to a given user.

This will be used to move some querying logic from the users controller
to the Event model (where it belongs).

This class now uses a UNION (when needed) instead of plucking tens of
thousands of project IDs into memory. The tests have also been
re-written to ensure all different use cases are tested properly
(assuming I didn't forget any cases).

The finder has also been broken up into 3 different finder classes:

* ContributedProjectsFinder: class for getting the projects a user
  contributed to.
* PersonalProjectsFinder: class for getting the personal projects of a
  user.
* ProjectsFinder: class for getting generic projects visible to a given
  user.

Previously a lot of the logic of these finders was handled directly in
the users controller.

In the previous setup the GroupsFinder class had two distinct tasks:

1. Finding the projects user A could see
2. Finding the projects of user A that user B could see

Task two was actually handled outside of the GroupsFinder (in the
UsersController) by restricting the returned list of groups to those the
viewed user was a member of. Moving all this logic into a single finder
proved to be far too complex and confusing, hence there are now two
finders:

* GroupsFinder: for finding groups a user can see
* JoinedGroupsFinder: for finding groups that user A is a member of,
  restricted to either public groups or groups user B can also see.