- 27 Mar, 2015 1 commit
-
-
Dmitriy Zaporozhets authored
-
- 26 Mar, 2015 27 commits
-
-
Dmitriy Zaporozhets authored
Set Application controller default URL options to ensure all url_for calls are consistent ### What does this MR do? This MR sets the app controller's `default_url_options` so that all `url_for` calls are consistent. ### Are there points in the code the reviewer needs to double check? Setting these options may simplify `url_for` calls that load the GitLab options already. I did not want to touch existing code yet. I'm also not sure if there are other options that need to be included. ### Why was this MR needed? If you run GitLab behind a reverse proxy or in a Docker container, you don't want a user to be seeing the local IP and port on which GitLab is running (e.g. 192.168.1.1:8080). Right now there are places where this internal data is leaked (e.g. see the URL in Profile Settings -> Account -> Username; this uses `user_url`). ### What are the relevant issue numbers / [Feature requests](http://feedback.gitlab.com/)? #1249 See merge request !453
-
Dmitriy Zaporozhets authored
Fix EmailsOnPush. See private issue https://dev.gitlab.org/gitlab/gitlabhq/issues/2185. See merge request !459
-
Dmitriy Zaporozhets authored
-
Dmitriy Zaporozhets authored
-
Dmitriy Zaporozhets authored
Add archived status to Admin > Project page
-
Dmitriy Zaporozhets authored
Renamed Buildbox to Buildkite.
-
Dmitriy Zaporozhets authored
Change directory when removing old backups Fixes errors when deleting old backups in the `gitlab:backup:create` rake task. See #2177. See merge request !1740
-
Dmitriy Zaporozhets authored
Capitalize js class name See merge request !457
-
Keith Pitt authored
-
Hannes Rosenögger authored
Fix broken side-by-side diff view on merge request page ### What does this MR do? This MR fixes the side-by-side diff that was broken in v7.9.0. The "Inline" and "Side-by-Side" buttons are now always rendered with HTML links instead of changing depending on whether the code diff was requested in JSON format. ### Are there points in the code the reviewer needs to double check? Is there a better way to fix this? The links in JSON format may be desirable if there were a JavaScript hook to handle the buttons, but as far as I can tell there isn't at the moment. ### Why was this MR needed? The issue is that the code diffs can be generated either by the JavaScript handler or the regular HTML. With the forcing of JSON request format in 27e75344, the JavaScript handler requests the page in JSON format, which it then uses to render the page. However, this has the unintended side effect of requesting that the "Inline" and "Side-by-Side" buttons have references to a JSON-formatted link. ### What are the relevant issue numbers / [Feature requests](http://feedback.gitlab.com/)? #1294 See merge request !460
-
Dmitriy Zaporozhets authored
UI improvements * Fix diff header for discussion * Remove unused doorkeeper layout * Nicer well * Replace alerts with well where alert is not needed See merge request !458
-
Stan Hu authored
Closes #1294
-
Douwe Maan authored
-
Dmitriy Zaporozhets authored
-
Dmitriy Zaporozhets authored
-
Dmitriy Zaporozhets authored
-
Dmitriy Zaporozhets authored
-
Dmitriy Zaporozhets authored
-
Dmitriy Zaporozhets authored
-
Dmitriy Zaporozhets authored
-
Dmitriy Zaporozhets authored
Prevent unnecessary doubling of js events on import pages and user calendar Adding document.ready in Turbolinks make duplicating of events EVERY visit of page. In example of user calendar it causes N+1 times ajax request every time you visit user page. cc @vsizov See merge request !456
-
Dmitriy Zaporozhets authored
-
Dmitriy Zaporozhets authored
Fix code unfold not working on Compare commits page ### What does this MR do? The code unfold buttons (`...`) don't work when you go to Commits -> Compare mode. This MR fixes that. ### Are there points in the code the reviewer needs to double check? Check to make sure all the right initializers are run in the `projects:compare:xxx` case. I'm also not sure if there are other cases where a diff is shown but the code unfolding is not activated. ### What are the relevant issue numbers / [Feature requests](http://feedback.gitlab.com/)? Closes #1274 See merge request !434
-
Dmitriy Zaporozhets authored
Change ordering so that confirm is removed from attrs before attempting to User.build_user Possible fix gitlab-org/gitlab-ce#1296 See merge request !445
-
Dmitriy Zaporozhets authored
[doc] Groups can be browsable if they contain at least one public project. See merge request !451
-
Dmitriy Zaporozhets authored
Notification on project moving Moving of project should respect notification settings https://dev.gitlab.org/gitlab/gitlabhq/issues/2091 See merge request !452
-
Dmitriy Zaporozhets authored
Prevent doubling AJAX request with each commit visit via Turbolink Be careful with `document.ready` in views
😃 cc @vsizov @marin See merge request !454
-
- 25 Mar, 2015 12 commits
-
-
Dmitriy Zaporozhets authored
-
Robert Speicher authored
-
Robert Speicher authored
-
Stan Hu authored
Closes #1249
-
Dmitriy Zaporozhets authored
Faster merge request processing for large repository
-
Dmitriy Zaporozhets authored
Allow HTML tags in user Markdown input
-
Valery Sizov authored
-
Dmitriy Zaporozhets authored
-
Dmitriy Zaporozhets authored
More rubocop styles See merge request !449
-
nicklegr authored
[ci skip]
-
nicklegr authored
* Reduces overhead of git checkout
-
Achilleas Pipinellis authored
-