Fix boneheaded regression test.

Using 'random' in a test exercising a known bug is a code stench.

Fix boneheaded regression test.
Using 'random' in a test exercising a known bug is a code stench.
56bd1d04 · Tres Seaver · a60b591d · 56bd1d04
Commit 56bd1d04 authored Dec 26, 2014 by Tres Seaver
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 3 deletions

BTrees/tests/testBTrees.py BTrees/tests/testBTrees.py +5 -3

No files found.
--- a/BTrees/tests/testBTrees.py
+++ b/BTrees/tests/testBTrees.py
@@ -313,9 +313,11 @@ class BugFixes(unittest.TestCase):
                t[id] = (id, ToBeDeleted(id), _u('somename'))
            else:
                #del
-                id = trandom.choice(list(ids.keys()))
+                keys = list(ids.keys())
-                del t[id]
+                if keys:
-                del ids[id]
+                    id = trandom.choice(keys)
+                    del t[id]
+                    del ids[id]
        ids = ids.keys()
        trandom.shuffle(list(ids))