Cleaned up / normalized imports:

o Don't import from Globals;  instead, use real locations.

o Make other imports use the actual source module, rather than an
  intermediate (e.g., prefer importing 'ClassSecurityInfo' from
  'AccessControl.SecurityInfo' rather than from 'AccessControl').

o Avoid relative imports, which will break in later versions of Python.

Products/DCWorkflow/CHANGES.txt

@@ -4,6 +4,16 @@ Products.DCWorkflow Changelog
 2.2.0 (unreleased)
 ------------------
 
+- Cleaned up / normalized imports:
+
+  o Don't import from Globals;  instead, use real locations.
+
+  o Make other imports use the actual source module, rather than an
+    intermediate (e.g., prefer importing 'ClassSecurityInfo' from
+    'AccessControl.SecurityInfo' rather than from 'AccessControl').
+
+  o Avoid relative imports, which will break in later versions of Python.
+
 - Strip trailing newlines in order to properly match with a msgid when
   translating transition descriptions.
 

Products/DCWorkflow/ContainerTab.py

@@ -15,7 +15,9 @@
 $Id$
 """
 
-from Acquisition import aq_base, aq_inner, aq_parent
+from Acquisition import aq_base
+from Acquisition import aq_inner
+from Acquisition import aq_parent
 from OFS.Folder import Folder
 
 _marker = []  # Create a new marker object.

Products/DCWorkflow/DCWorkflow.py

@@ -16,13 +16,13 @@ $Id$
 """
 
 # Zope
-from AccessControl import ClassSecurityInfo
-from AccessControl import getSecurityManager
-from AccessControl import Unauthorized
+from AccessControl.SecurityInfo import ClassSecurityInfo
+from AccessControl.SecurityManagement import getSecurityManager
+from AccessControl.unauthorized import Unauthorized
 from Acquisition import aq_inner
 from Acquisition import aq_parent
+from App.class_init import default__class_init__ as InitializeClass
 from DocumentTemplate.DT_Util import TemplateDict
-from Globals import InitializeClass
 from OFS.Folder import Folder
 from OFS.ObjectManager import bad_id
 from zope.event import notify
@@ -36,17 +36,18 @@ from Products.CMFCore.WorkflowCore import ObjectMoved
 from Products.CMFCore.WorkflowCore import WorkflowException
 
 # DCWorkflow
-from events import BeforeTransitionEvent, AfterTransitionEvent
-from Expression import createExprContext
-from Expression import StateChangeInfo
-from interfaces import IDCWorkflowDefinition
-from permissions import ManagePortal
-from Transitions import TRIGGER_AUTOMATIC
-from Transitions import TRIGGER_USER_ACTION
-from utils import Message as _
-from utils import modifyRolesForGroup
-from utils import modifyRolesForPermission
-from WorkflowUIMixin import WorkflowUIMixin
+from Products.DCWorkflow.events import AfterTransitionEvent
+from Products.DCWorkflow.events import BeforeTransitionEvent
+from Products.DCWorkflow.Expression import createExprContext
+from Products.DCWorkflow.Expression import StateChangeInfo
+from Products.DCWorkflow.interfaces import IDCWorkflowDefinition
+from Products.DCWorkflow.permissions import ManagePortal
+from Products.DCWorkflow.Transitions import TRIGGER_AUTOMATIC
+from Products.DCWorkflow.Transitions import TRIGGER_USER_ACTION
+from Products.DCWorkflow.utils import Message as _
+from Products.DCWorkflow.utils import modifyRolesForGroup
+from Products.DCWorkflow.utils import modifyRolesForPermission
+from Products.DCWorkflow.WorkflowUIMixin import WorkflowUIMixin
 
 def checkId(id):
     res = bad_id(id)

Products/DCWorkflow/Expression.py

@@ -16,11 +16,13 @@ $Id$
 """
 from warnings import warn
 
-import Globals
-from Globals import Persistent
-from Acquisition import aq_inner, aq_parent
-from AccessControl import getSecurityManager, ClassSecurityInfo
-from DateTime import DateTime
+from AccessControl.SecurityInfo import ClassSecurityInfo
+from AccessControl.SecurityManagement import getSecurityManager
+from Acquisition import aq_inner
+from Acquisition import aq_parent
+from App.class_init import default__class_init__ as InitializeClass
+from DateTime.DateTime import DateTime
+from Persistence import Persistent
 
 from Products.CMFCore.WorkflowCore import ObjectDeleted, ObjectMoved
 from Products.CMFCore.Expression import Expression
@@ -118,7 +120,7 @@ class StateChangeInfo:
             date = self._date = DateTime()
         return date
 
-Globals.InitializeClass(StateChangeInfo)
+InitializeClass(StateChangeInfo)
 
 
 def createExprContext(sci):

Products/DCWorkflow/Guard.py

@@ -17,20 +17,20 @@ $Id$
 
 from cgi import escape
 
-from Globals import DTMLFile
-from Globals import InitializeClass
-from Globals import Persistent
-from AccessControl import ClassSecurityInfo
+from AccessControl.SecurityInfo import ClassSecurityInfo
 from Acquisition import Explicit
 from Acquisition import aq_base
+from App.class_init import default__class_init__ as InitializeClass
+from App.special_dtml import DTMLFile
+from Persistence import Persistent
 
 from Products.CMFCore.utils import _checkPermission
 
-from Expression import Expression
-from Expression import StateChangeInfo
-from Expression import createExprContext
-from permissions import ManagePortal
-from utils import _dtmldir
+from Products.DCWorkflow.Expression import Expression
+from Products.DCWorkflow.Expression import StateChangeInfo
+from Products.DCWorkflow.Expression import createExprContext
+from Products.DCWorkflow.permissions import ManagePortal
+from Products.DCWorkflow.utils import _dtmldir
 
 
 class Guard (Persistent, Explicit):

Products/DCWorkflow/Scripts.py

@@ -15,12 +15,12 @@
 $Id$
 """
 
+from AccessControl.SecurityInfo import ClassSecurityInfo
+from App.class_init import default__class_init__ as InitializeClass
 from OFS.Folder import Folder
-from Globals import InitializeClass
-from AccessControl import ClassSecurityInfo
 
-from ContainerTab import ContainerTab
-from permissions import ManagePortal
+from Products.DCWorkflow.ContainerTab import ContainerTab
+from Products.DCWorkflow.permissions import ManagePortal
 
 
 class Scripts (ContainerTab):

Products/DCWorkflow/States.py

@@ -15,19 +15,19 @@
 $Id$
 """
 
-from AccessControl import ClassSecurityInfo
 from AccessControl.requestmethod import postonly
+from AccessControl.SecurityInfo import ClassSecurityInfo
 from Acquisition import aq_inner
 from Acquisition import aq_parent
-from Globals import DTMLFile
-from Globals import InitializeClass
-from Globals import PersistentMapping
+from App.class_init import default__class_init__ as InitializeClass
+from App.special_dtml import DTMLFile
+from Persistence import PersistentMapping
 from OFS.SimpleItem import SimpleItem
 from Products.PageTemplates.PageTemplateFile import PageTemplateFile
 
-from ContainerTab import ContainerTab
-from permissions import ManagePortal
-from utils import _dtmldir
+from Products.DCWorkflow.ContainerTab import ContainerTab
+from Products.DCWorkflow.permissions import ManagePortal
+from Products.DCWorkflow.utils import _dtmldir
 
 
 class StateDefinition(SimpleItem):

Products/DCWorkflow/Transitions.py

@@ -15,19 +15,19 @@
 $Id$
 """
 
-from OFS.SimpleItem import SimpleItem
-from Globals import DTMLFile
-from Globals import PersistentMapping
-from Globals import InitializeClass
+from AccessControl import ClassSecurityInfo
 from Acquisition import aq_inner
 from Acquisition import aq_parent
-from AccessControl import ClassSecurityInfo
+from App.class_init import default__class_init__ as InitializeClass
+from App.special_dtml import DTMLFile
+from OFS.SimpleItem import SimpleItem
+from Persistence import PersistentMapping
 
-from ContainerTab import ContainerTab
-from Guard import Guard
-from permissions import ManagePortal
-from utils import _dtmldir
-from Expression import Expression
+from Products.DCWorkflow.ContainerTab import ContainerTab
+from Products.DCWorkflow.Guard import Guard
+from Products.DCWorkflow.permissions import ManagePortal
+from Products.DCWorkflow.utils import _dtmldir
+from Products.DCWorkflow.Expression import Expression
 
 TRIGGER_AUTOMATIC = 0
 TRIGGER_USER_ACTION = 1

Products/DCWorkflow/Variables.py

@@ -15,18 +15,18 @@
 $Id$
 """
 
-from AccessControl import ClassSecurityInfo
+from AccessControl.SecurityInfo import ClassSecurityInfo
 from Acquisition import aq_inner
 from Acquisition import aq_parent
-from Globals import DTMLFile
-from Globals import InitializeClass
+from App.class_init import default__class_init__ as InitializeClass
+from App.special_dtml import DTMLFile
 from OFS.SimpleItem import SimpleItem
 
-from ContainerTab import ContainerTab
-from Expression import Expression
-from Guard import Guard
-from permissions import ManagePortal
-from utils import _dtmldir
+from Products.DCWorkflow.ContainerTab import ContainerTab
+from Products.DCWorkflow.Expression import Expression
+from Products.DCWorkflow.Guard import Guard
+from Products.DCWorkflow.permissions import ManagePortal
+from Products.DCWorkflow.utils import _dtmldir
 
 
 class VariableDefinition(SimpleItem):

Products/DCWorkflow/WorkflowUIMixin.py

@@ -17,17 +17,17 @@ $Id$
 
 import os
 
-from Globals import DTMLFile
-from Globals import InitializeClass
-from AccessControl import ClassSecurityInfo
 from AccessControl.requestmethod import postonly
+from AccessControl.SecurityInfo import ClassSecurityInfo
+from App.class_init import default__class_init__ as InitializeClass
+from App.special_dtml import DTMLFile
 from Acquisition import aq_get
 
 from Products.PageTemplates.PageTemplateFile import PageTemplateFile
 
-from permissions import ManagePortal
-from Guard import Guard
-from utils import _dtmldir
+from Products.DCWorkflow.permissions import ManagePortal
+from Products.DCWorkflow.Guard import Guard
+from Products.DCWorkflow.utils import _dtmldir
 
 
 class WorkflowUIMixin:

Products/DCWorkflow/Worklists.py

@@ -15,18 +15,18 @@
 $Id$
 """
 
-from AccessControl import ClassSecurityInfo
+from AccessControl.SecurityInfo import ClassSecurityInfo
 from Acquisition import aq_inner
 from Acquisition import aq_parent
-from Globals import DTMLFile
-from Globals import InitializeClass
-from Globals import PersistentMapping
+from App.class_init import default__class_init__ as InitializeClass
+from App.special_dtml import DTMLFile
+from Persistence import PersistentMapping
 from OFS.SimpleItem import SimpleItem
 
-from ContainerTab import ContainerTab
-from Guard import Guard
-from permissions import ManagePortal
-from utils import _dtmldir
+from Products.DCWorkflow.ContainerTab import ContainerTab
+from Products.DCWorkflow.Guard import Guard
+from Products.DCWorkflow.permissions import ManagePortal
+from Products.DCWorkflow.utils import _dtmldir
 
 
 class WorklistDefinition(SimpleItem):

Products/DCWorkflow/__init__.py

@@ -15,12 +15,16 @@
 $Id$
 """
 
-from Products.CMFCore.utils import registerIcon
-
-import DCWorkflow, States, Transitions, Variables, Worklists, Scripts
+def initialize(context):
 
+    from Products.CMFCore.utils import registerIcon
 
-def initialize(context):
+    import DCWorkflow
+    import States
+    import Transitions
+    import Variables
+    import Worklists
+    import Scripts
 
     context.registerHelp(directory='help')
     context.registerHelpTitle('DCWorkflow')

Products/DCWorkflow/events.py

 from zope.interface import implements
 from zope.component.interfaces import ObjectEvent
 
-from interfaces import ITransitionEvent, IBeforeTransitionEvent, IAfterTransitionEvent
+from Products.DCWorkflow.interfaces import IAfterTransitionEvent
+from Products.DCWorkflow.interfaces import IBeforeTransitionEvent
+from Products.DCWorkflow.interfaces import ITransitionEvent
 
 class TransitionEvent(ObjectEvent):
     implements(ITransitionEvent)
     
-    def __init__(self, obj, workflow, old_state, new_state, transition, status, kwargs):
+    def __init__(self, obj, workflow, old_state, new_state,
+                 transition, status, kwargs):
         ObjectEvent.__init__(self, obj)
         self.workflow = workflow
         self.old_state = old_state
@@ -19,4 +22,4 @@ class BeforeTransitionEvent(TransitionEvent):
     implements(IBeforeTransitionEvent)
     
 class AfterTransitionEvent(TransitionEvent):
-    implements(IAfterTransitionEvent)
\ No newline at end of file
+    implements(IAfterTransitionEvent)

Products/DCWorkflow/exportimport.py

@@ -18,20 +18,20 @@ $Id$
 import re
 from xml.dom.minidom import parseString
 
-from Expression import Expression
-from AccessControl import ClassSecurityInfo
+from AccessControl.SecurityInfo import ClassSecurityInfo
 from Acquisition import Implicit
-from Globals import InitializeClass
+from App.class_init import default__class_init__ as InitializeClass
 from Products.PageTemplates.PageTemplateFile import PageTemplateFile
 from zope.component import adapts
 
 from Products.GenericSetup.interfaces import ISetupEnviron
 from Products.GenericSetup.utils import BodyAdapterBase
 
-from utils import _xmldir
-from DCWorkflow import DCWorkflowDefinition
-from interfaces import IDCWorkflowDefinition
-from permissions import ManagePortal
+from Products.DCWorkflow.DCWorkflow import DCWorkflowDefinition
+from Products.DCWorkflow.Expression import Expression
+from Products.DCWorkflow.interfaces import IDCWorkflowDefinition
+from Products.DCWorkflow.permissions import ManagePortal
+from Products.DCWorkflow.utils import _xmldir
 
 
 TRIGGER_TYPES = ( 'AUTOMATIC', 'USER' )

Products/DCWorkflow/interfaces.py

@@ -15,7 +15,8 @@
 $Id$
 """
 
-from zope.interface import Interface, Attribute
+from zope.interface import Attribute
+from zope.interface import Interface
 from zope.component.interfaces import IObjectEvent
 
 class IDCWorkflowDefinition(Interface):

Products/DCWorkflow/utils.py

@@ -17,9 +17,9 @@ $Id$
 
 import os
 
-from AccessControl import ModuleSecurityInfo
 from AccessControl.Permission import Permission
 from AccessControl.Role import gather_permissions
+from AccessControl.SecurityInfo import ModuleSecurityInfo
 from App.Common import package_home
 from zope.i18nmessageid import MessageFactory