- 17 Mar, 2022 7 commits
-
-
Kirill Smelkov authored
* master: - vb [ci skip] - force recognizing ellipsis - try to fix changed traceback representation - select more specific pypy versions - prepare release 5.7.0 - revert 5b8e2dc1
-
Jens Vagelpohl authored
-
Jens Vagelpohl authored
-
Jens Vagelpohl authored
-
Jens Vagelpohl authored
-
Jens Vagelpohl authored
-
Jens Vagelpohl authored
-
- 11 Nov, 2021 2 commits
-
-
Kirill Smelkov authored
Sorry, but some of flake8 complaints are really stupid...
-
Kirill Smelkov authored
Resolve many conflicts after https://github.com/zopefoundation/ZODB/pull/357. * master: Let the year float. Configuring for pure-python Specify a PyPy2 version. Lint the code. Configuring for pure-python
-
- 09 Nov, 2021 2 commits
-
-
Michael Howitz authored
-
Michael Howitz authored
* Config with pure python * Lint the code. * Add support for Python 3.9 and 3.10.
-
- 05 Nov, 2021 2 commits
-
-
Michael Howitz authored
-
Michael Howitz authored
-
- 29 Oct, 2021 3 commits
-
-
Kirill Smelkov authored
to resolve trivial conflict on CHANGES.rst * origin/master: (22 commits) Fix TypeError for fsoids (#351) Fix deprecation warnings occurring on Python 3.10. fix more PY3 incompatibilities in `fsstats` fix Python 3 incompatibility for `fsstats` add `fsdump/fsstats` test fsdump/fsstats improvements - add coverage combine step - first cut moving tests from Travis CI to GitHub Actions - ignore virtualenv artifacts [ci skip] tests: Run race-related tests with high frequency of switches between threads tests: Add test for load vs external invalidation race tests: Add test for open vs invalidation race fixup! doc/requirements: Require pygments < 2.6 on py2 doc/requirements: Require pygments < 2.6 on py2 fixup! buildout: Fix Sphinx install on Python2 buildout: Fix Sphinx install on Python2 Update README.rst Security fix documentation dependencies (#342) changes: Correct link to UnboundLocalError fsoids.py fix fsrefs: Optimize IO (take 2) (#340) ...
-
Michael Howitz authored
Add support for Python 3.9 and 3.10.
-
Michael Howitz authored
-
- 28 Oct, 2021 1 commit
-
-
Alessandro Pisa authored
Fix `TypeError: can't concat str to bytes` when running fsoids.py script with Python 3. Closes #350
-
- 27 Oct, 2021 1 commit
-
-
Michael Howitz authored
-
- 06 Oct, 2021 1 commit
-
-
Dieter Maurer authored
fsdump/fsstats improvements
-
- 05 Oct, 2021 3 commits
- 03 Oct, 2021 1 commit
-
-
dieter authored
-
- 06 Jun, 2021 1 commit
-
-
Kirill Smelkov authored
Dieter Maurer notes that loadBefore cannot be deprecated yet because ZEO essentially depends on the `end_tid` information returned by loadBefore to update its cache: https://github.com/zopefoundation/ZODB/pull/323#issuecomment-842021970 And to remove this dependency it would require to rework ZODB caching layer: https://github.com/zopefoundation/ZODB/pull/323#issuecomment-845917355 So we cannot deprecate loadBefore until this rework is implemented first. -> Remove general loadBefore deprecation, and emit loadBefore vs loadBeforeEx warning only when actually hitting a "deletion" record, because only that case is known to lead to data corruption.
-
- 11 May, 2021 1 commit
-
-
Dieter Maurer authored
@d-maurer says (https://github.com/zopefoundation/ZODB/pull/323#discussion_r627929959): The changes around `loadBeforeEx` have much more impact than the `DemoStorage` fix. -------- kirr: adjusted the text a bit: "Introduces" -> "Introduce"; add "interface". @d-maurer, I hope it is ok.
-
- 06 May, 2021 2 commits
-
-
Kirill Smelkov authored
The changelog entry uses loadBeforeEx, but we are likely to change this name during https://github.com/zopefoundation/ZODB/pull/323 review.
-
Kirill Smelkov authored
loadBeforeEx uses the same docstring as loadBefore as @d-maurer suggests: https://github.com/zopefoundation/ZODB/pull/323#discussion_r626255153
-
- 04 May, 2021 3 commits
-
-
Kirill Smelkov authored
@d-maurer suggests to keep loadBefore without deprecation (https://github.com/zopefoundation/ZODB/pull/323#pullrequestreview-650963363). -> Don't emit warnings about deprecating loadBefore. -> Keep the deprecation text in loadBefore interface, since loadBeforeEx should practically provide wider functionality without putting unnecessary constraint on storage implementations. In other words loadBefore deprecation is still there, but less aggressively advertised with the idea to make transition for outside-of-ZODB code to loadBeforeEx more smooth and with a bit more steps (we might want to reinstate the deprecation warnings at a later time).
-
Kirill Smelkov authored
Suggested by @d-maurer: https://github.com/zopefoundation/ZODB/pull/323#discussion_r625573381
-
Kirill Smelkov authored
@d-maurer suggests[1]: The ZODB logic relating to historical data (including MVCC) was largely centered around before. You have changed this to at - requiring wide spread modifications. I would much prefer to keep the before centered approach... (https://github.com/zopefoundation/ZODB/pull/323#pullrequestreview-650963363) So let's change "at"-based logic to "before"-based logic and rename the new method from loadAt to loadBeforeEx.
-
- 03 May, 2021 1 commit
-
-
Jens Vagelpohl authored
Define the official expansion of "ZODB"
-
- 23 Apr, 2021 4 commits
-
-
Jens Vagelpohl authored
Switch from Travis CI to GitHub Actions for testing
-
Jens Vagelpohl authored
-
Jens Vagelpohl authored
-
Jens Vagelpohl authored
-
- 21 Apr, 2021 3 commits
-
-
Kirill Smelkov authored
As suggested by @d-maurer: https://github.com/zopefoundation/ZODB/pull/345#issuecomment-822188305 https://github.com/zopefoundation/ZEO/issues/168#issuecomment-821829116 /reviewed-on https://github.com/zopefoundation/ZODB/pull/345
-
Kirill Smelkov authored
For ZEO this data corruption bug was reported at https://github.com/zopefoundation/ZEO/issues/155 and fixed at https://github.com/zopefoundation/ZEO/pull/169. Without that fix the failure shows e.g. as follows when running ZEO test suite: Failure in test check_race_load_vs_external_invalidate (ZEO.tests.testZEO.BlobAdaptedFileStorageTests) Traceback (most recent call last): File "/usr/lib/python2.7/unittest/case.py", line 329, in run testMethod() File "/home/kirr/src/wendelin/z/ZODB/src/ZODB/tests/BasicStorage.py", line 621, in check_race_load_vs_external_invalidate self.fail([_ for _ in failure if _]) File "/usr/lib/python2.7/unittest/case.py", line 410, in fail raise self.failureException(msg) AssertionError: ['T1: obj1.value (7) != obj2.value (8)'] Even if added test is somewhat similar to check_race_loadopen_vs_local_invalidate, it is added anew without trying to unify code. The reason here is that the probability to catch load vs external invalidation race is significantly reduced when there are only 1 modify and 1 verify workers. The unification with preserving both tests semantic would make test for "load vs local invalidate" harder to follow. Sometimes a little copying is better than trying to unify too much. For the test to work, test infrastructure is amended with ._new_storage_client() method that complements ._storage attribute: client-server storages like ZEO, NEO and RelStorage allow several storage clients to be connected to single storage server. For client-server storages test subclasses should implement _new_storage_client to return new storage client that is connected to the same storage server self._storage is connected to. For ZEO ._new_storage_client() is added by https://github.com/zopefoundation/ZEO/pull/170 Other client-server storages can follow to implement ._new_storage_client() and this way automatically activate this "load vs external invalidation" test when their testsuite is run. Contrary to test for "load vs local invalidate" N is set to lower value (100), because with 8 workers the bug is usually reproduced at not-so-high iteration number (5-10-20). /cc @d-maurer, @jamadden, @jmuchemb /reviewed-on https://github.com/zopefoundation/ZODB/pull/345
-
Kirill Smelkov authored
Add test that exercises open vs invalidation race condition that, if happen, leads to data corruption. We are seeing such race happening on storage level in ZEO (https://github.com/zopefoundation/ZEO/issues/166), and previously we've seen it also to happen on Connection level (https://github.com/zopefoundation/ZODB/issues/290). By adding this test to be exercised wrt all storages we make sure that all storages stay free from this race. And it payed out. Besides catching original problems from https://github.com/zopefoundation/ZODB/issues/290 and https://github.com/zopefoundation/ZEO/issues/166 , this test also discovered a concurrency bug in MVCCMappingStorage: Failure in test check_race_open_vs_invalidate (ZODB.tests.testMVCCMappingStorage.MVCCMappingStorageTests) Traceback (most recent call last): File "/usr/lib/python2.7/unittest/case.py", line 329, in run testMethod() File "/home/kirr/src/wendelin/z/ZODB/src/ZODB/tests/BasicStorage.py", line 492, in check_race_open_vs_invalidate self.fail(failure[0]) File "/usr/lib/python2.7/unittest/case.py", line 410, in fail raise self.failureException(msg) AssertionError: T1: obj1.value (24) != obj2.value (23) The problem with MVCCMappingStorage was that instance.poll_invalidations was correctly taking main_lock with intention to make sure main data is not mutated during analysis, but instance.tpc_finish and instance.tpc_abort did _not_ taken main lock, which was leading to committed data to be propagating into main storage in non-atomic way. This bug was also observable if both obj1 and obj2 in the added test were always loaded from the storage (added obj2._p_invalidate after obj1._p_invalidate). -> Fix MVCCMappingStorage by correctly locking main MVCCMappingStorage instance when processing transaction completion. /cc @d-maurer, @jamadden, @jmuchemb /reviewed-on https://github.com/zopefoundation/ZODB/pull/345
-
- 20 Apr, 2021 2 commits
-
-
Kirill Smelkov authored
buildout: Fix CI /reviewed-on https://github.com/zopefoundation/ZODB/pull/346 /reviewed-by @d-maurer
-
Kirill Smelkov authored
-