GitLab

Removed various persistent product related code and options. The `enable-product-installation` `zope.conf` setting is now a no-op.

Prevent ZopeTestCase to load any ZCML as a side-effect of calling Zope2.app(). Loading ZCML has to be deferred to layer setup time.

- no need to re-raise Redirect in raise_standardErrorMessage (ZPublisherExceptionHook is responsible for that)

In previous Zope versions string exceptions were used and all exceptions
re-raised. This doesn't work with each kind of exception, but we can still do
it with Unauthorized exceptions. This way the special handling for Unauthorized
exceptions works again, HTTPResponse._unauthorized is called again. This is now
done after rendering to make sure we don't break logging and custom views.

In previous Zope versions string exceptions were used and all exceptions
re-raised. This doesn't work with each kind of exception, but we can still do
it with Unauthorized exceptions. This way the special handling for Unauthorized
exceptions works again, HTTPResponse._unauthorized is called again. This is now
done after rendering to make sure we don't break logging and custom views.

Moved the code handling ZCML loading into the ``Zope2.App`` package. The component architecture is now setup before the application object is created or any database connections are opened. So far the CA was setup somewhat randomly in the startup process, when the ``Five`` product was initialized.

Use Tres' handy upgradeException function, to make the ExceptionHookTest work across Python versions

Removed handling of string exceptions from ZPublisherExceptionHook and reverted the addition of Unauthorized exceptions to be always re-raised. This broke the tests.

Catch up with the rest of the Zope Toolkit of the day and loose dependencies on zope.app.appsetup, zope.app.component and zope.app.container.

Removed more unused code of the versions support feature including the Globals.VersionNameName constant.

o Replaced  imports from the 'Globals' module throughout the tree with
  imports from the actual modules;  the 'Globals' module was always intended
  to be an area for shared data, rather than a "facade" for imports.

o Added 'zope.deferredimport.deprecation' entries to 'Globals/__init__.py'
  for all previously imported symbols / modules.

o Moved 'ApplicationdefaultPermissions' from 'App/class_init.py' to
  'AccessCoontrol/Permission.py', to avoid possible import cycle in
  third-party code.

o Moved canonical location of UNIQUE / REPLACEABLE / NOT_REPLACEABLE
  constants from 'Globals' to 'OFS.ObjectManager'.

o Removed 'stuffGlobals' hack in favor of the deferred / deprecation
  imports.

Add check for doomed transactions in default transaction manager, abort silently if the tm tries to commit a doomed transaction

 - Rather nasty fix to work around Zope 3 exceptions that have more than one positional argument on the constructor. Also, pass 'handle_errors' argument used for functional http testing around and use that on raise_standardErrorMessage to decide if we need to care about rendering a full HTML traceback.

  2.6. Adjust tests accordingly.

work done for Infrae.