Add codegen tests for && and ||

src/codegen_llvm.cpp

@@ -289,6 +289,7 @@ void CodegenLLVM::visit(Binop &binop)
 
 void CodegenLLVM::visit(Unop &unop)
 {
+  assert(unop.expr->type.type == Type::integer);
   unop.expr->accept(*this);
 
   switch (unop.op) {
@@ -304,8 +305,6 @@ void CodegenLLVM::visit(Unop &unop)
     }
     default: abort();
   }
-
-  // Unops only operate on integer values, so no need for lifetime end
 }
 
 void CodegenLLVM::visit(ExprStatement &expr)
@@ -465,6 +464,9 @@ AllocaInst *CodegenLLVM::getQuantizeMapKey(Map &map, Value *log2)
 
 Value *CodegenLLVM::createLogicalAnd(Binop &binop)
 {
+  assert(binop.left->type.type == Type::integer);
+  assert(binop.right->type.type == Type::integer);
+
   Function *parent = b_.GetInsertBlock()->getParent();
   BasicBlock *lhs_true_block = BasicBlock::Create(module_->getContext(), "&&_lhs_true", parent);
   BasicBlock *true_block = BasicBlock::Create(module_->getContext(), "&&_true", parent);
@@ -501,6 +503,9 @@ Value *CodegenLLVM::createLogicalAnd(Binop &binop)
 
 Value *CodegenLLVM::createLogicalOr(Binop &binop)
 {
+  assert(binop.left->type.type == Type::integer);
+  assert(binop.right->type.type == Type::integer);
+
   Function *parent = b_.GetInsertBlock()->getParent();
   BasicBlock *lhs_false_block = BasicBlock::Create(module_->getContext(), "||_lhs_false", parent);
   BasicBlock *false_block = BasicBlock::Create(module_->getContext(), "||_false", parent);

tests/codegen.cpp

@@ -644,7 +644,7 @@ attributes #1 = { argmemonly nounwind }
 )EXPECTED");
 }
 
-TEST(codegen, builtin_quantize)
+TEST(codegen, call_quantize)
 {
   test("kprobe:f { @x = quantize(pid) }",
 
@@ -715,7 +715,7 @@ attributes #1 = { argmemonly nounwind }
 )EXPECTED");
 }
 
-TEST(codegen, builtin_count)
+TEST(codegen, call_count)
 {
   test("kprobe:f { @x = count() }",
 
@@ -762,7 +762,7 @@ attributes #1 = { argmemonly nounwind }
 )EXPECTED");
 }
 
-TEST(codegen, builtin_str)
+TEST(codegen, call_str)
 {
   test("kprobe:f { @x = str(arg0) }",
 
@@ -808,7 +808,7 @@ attributes #1 = { argmemonly nounwind }
 )EXPECTED");
 }
 
-TEST(codegen, builtin_delete)
+TEST(codegen, call_delete)
 {
   test("kprobe:f { @x = delete() }",
 
@@ -838,7 +838,7 @@ attributes #1 = { argmemonly nounwind }
 )EXPECTED");
 }
 
-TEST(codegen, builtin_printf)
+TEST(codegen, call_printf)
 {
   test("kprobe:f { printf(\"hello\\n\") }",
 
@@ -1139,6 +1139,108 @@ attributes #1 = { argmemonly nounwind }
 )EXPECTED");
 }
 
+TEST(codegen, logical_or)
+{
+  test("kprobe:f { @x = pid == 1234 || pid == 1235 }",
+
+R"EXPECTED(; Function Attrs: nounwind
+declare i64 @llvm.bpf.pseudo(i64, i64) #0
+
+; Function Attrs: argmemonly nounwind
+declare void @llvm.lifetime.start(i64, i8* nocapture) #1
+
+define i64 @"kprobe:f"(i8* nocapture readnone) local_unnamed_addr section "kprobe:f" {
+entry:
+  %"@x_val" = alloca i64, align 8
+  %"@x_key" = alloca i64, align 8
+  %get_pid_tgid = tail call i64 inttoptr (i64 14 to i64 ()*)()
+  %.mask = and i64 %get_pid_tgid, -4294967296
+  %1 = icmp eq i64 %.mask, 5299989643264
+  br i1 %1, label %"||_true", label %"||_lhs_false"
+
+"||_lhs_false":                                   ; preds = %entry
+  %get_pid_tgid1 = tail call i64 inttoptr (i64 14 to i64 ()*)()
+  %.mask2 = and i64 %get_pid_tgid1, -4294967296
+  %2 = icmp eq i64 %.mask2, 5304284610560
+  br i1 %2, label %"||_true", label %"||_merge"
+
+"||_true":                                        ; preds = %"||_lhs_false", %entry
+  br label %"||_merge"
+
+"||_merge":                                       ; preds = %"||_lhs_false", %"||_true"
+  %"||_result.0" = phi i64 [ 1, %"||_true" ], [ 0, %"||_lhs_false" ]
+  %3 = bitcast i64* %"@x_key" to i8*
+  call void @llvm.lifetime.start(i64 -1, i8* %3)
+  store i64 0, i64* %"@x_key", align 8
+  %4 = bitcast i64* %"@x_val" to i8*
+  call void @llvm.lifetime.start(i64 -1, i8* %4)
+  store i64 %"||_result.0", i64* %"@x_val", align 8
+  %pseudo = tail call i64 @llvm.bpf.pseudo(i64 1, i64 1)
+  %update_elem = call i64 inttoptr (i64 2 to i64 (i8*, i8*, i8*, i64)*)(i64 %pseudo, i64* nonnull %"@x_key", i64* nonnull %"@x_val", i64 0)
+  call void @llvm.lifetime.end(i64 -1, i8* %3)
+  call void @llvm.lifetime.end(i64 -1, i8* %4)
+  ret i64 0
+}
+
+; Function Attrs: argmemonly nounwind
+declare void @llvm.lifetime.end(i64, i8* nocapture) #1
+
+attributes #0 = { nounwind }
+attributes #1 = { argmemonly nounwind }
+)EXPECTED");
+}
+
+TEST(codegen, logical_and)
+{
+  test("kprobe:f { @x = pid != 1234 && pid != 1235 }",
+
+R"EXPECTED(; Function Attrs: nounwind
+declare i64 @llvm.bpf.pseudo(i64, i64) #0
+
+; Function Attrs: argmemonly nounwind
+declare void @llvm.lifetime.start(i64, i8* nocapture) #1
+
+define i64 @"kprobe:f"(i8* nocapture readnone) local_unnamed_addr section "kprobe:f" {
+entry:
+  %"@x_val" = alloca i64, align 8
+  %"@x_key" = alloca i64, align 8
+  %get_pid_tgid = tail call i64 inttoptr (i64 14 to i64 ()*)()
+  %.mask = and i64 %get_pid_tgid, -4294967296
+  %1 = icmp eq i64 %.mask, 5299989643264
+  br i1 %1, label %"&&_false", label %"&&_lhs_true"
+
+"&&_lhs_true":                                    ; preds = %entry
+  %get_pid_tgid1 = tail call i64 inttoptr (i64 14 to i64 ()*)()
+  %.mask2 = and i64 %get_pid_tgid1, -4294967296
+  %2 = icmp eq i64 %.mask2, 5304284610560
+  br i1 %2, label %"&&_false", label %"&&_merge"
+
+"&&_false":                                       ; preds = %"&&_lhs_true", %entry
+  br label %"&&_merge"
+
+"&&_merge":                                       ; preds = %"&&_lhs_true", %"&&_false"
+  %"&&_result.0" = phi i64 [ 0, %"&&_false" ], [ 1, %"&&_lhs_true" ]
+  %3 = bitcast i64* %"@x_key" to i8*
+  call void @llvm.lifetime.start(i64 -1, i8* %3)
+  store i64 0, i64* %"@x_key", align 8
+  %4 = bitcast i64* %"@x_val" to i8*
+  call void @llvm.lifetime.start(i64 -1, i8* %4)
+  store i64 %"&&_result.0", i64* %"@x_val", align 8
+  %pseudo = tail call i64 @llvm.bpf.pseudo(i64 1, i64 1)
+  %update_elem = call i64 inttoptr (i64 2 to i64 (i8*, i8*, i8*, i64)*)(i64 %pseudo, i64* nonnull %"@x_key", i64* nonnull %"@x_val", i64 0)
+  call void @llvm.lifetime.end(i64 -1, i8* %3)
+  call void @llvm.lifetime.end(i64 -1, i8* %4)
+  ret i64 0
+}
+
+; Function Attrs: argmemonly nounwind
+declare void @llvm.lifetime.end(i64, i8* nocapture) #1
+
+attributes #0 = { nounwind }
+attributes #1 = { argmemonly nounwind }
+)EXPECTED");
+}
+
 } // namespace codegen
 } // namespace test
 } // namespace bpftrace