• R David Murray's avatar
    #23792: Ignore KeyboardInterrupt when the pydoc pager is active. · f331c5af
    R David Murray authored
    Previously, if you hit ctl-c while the pager was active, the python that
    launched the subprocess for the pager would see the KeyboardInterrupt in the
    __exit__ method of the subprocess context manager where it was waiting for the
    subprocess to complete, ending the wait.  This would leave the pager running,
    while the interactive interpreter, after handling the exception by printing
    it, would go back to trying to post a prompt...but the pager would generally
    have the terminal in raw mode, and in any case would be still trying to read
    from stdin.  On some systems, even exiting python at that point would not
    restore the terminal mode.  The problem with raw mode could also happen if
    ctl-C was hit when pydoc was called from the shell command line and the pager
    was active.
    
    Instead, we now wait on the subprocess in a loop, ignoring KeyboardInterrupt
    just like the pager does, until the pager actually exits.
    
    (Note: this was a regression relative to python2...in python2 the pager
    is called via system, and system does not return until the pager exits.)
    f331c5af
NEWS 371 KB