Fix leaks in Python-ast.c (#16127)

0247e80f · Eddie Elizondo · Dino Viehland · 279f4467 · 0247e80f · 0247e80f
Commit 0247e80f authored Sep 14, 2019 by Eddie Elizondo Committed by Dino Viehland Sep 14, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 10 additions and 2 deletions

Parser/asdl_c.py Parser/asdl_c.py +5 -1

Python/Python-ast.c Python/Python-ast.c +5 -1

No files found.
--- a/Parser/asdl_c.py
+++ b/Parser/asdl_c.py
@@ -638,9 +638,13 @@ static void
 ast_dealloc(AST_object *self)
 {
    /* bpo-31095: UnTrack is needed before calling any callbacks */
+    PyTypeObject *tp = Py_TYPE(self);
    PyObject_GC_UnTrack(self);
    Py_CLEAR(self->dict);
-    Py_TYPE(self)->tp_free(self);
+    freefunc free_func = PyType_GetSlot(tp, Py_tp_free);
+    assert(free_func != NULL);
+    free_func(self);
+    Py_DECREF(tp);
 }

 static int

--- a/Python/Python-ast.c
+++ b/Python/Python-ast.c
@@ -1130,9 +1130,13 @@ static void
 ast_dealloc(AST_object *self)
 {
    /* bpo-31095: UnTrack is needed before calling any callbacks */
+    PyTypeObject *tp = Py_TYPE(self);
    PyObject_GC_UnTrack(self);
    Py_CLEAR(self->dict);
-    Py_TYPE(self)->tp_free(self);
+    freefunc free_func = PyType_GetSlot(tp, Py_tp_free);
+    assert(free_func != NULL);
+    free_func(self);
+    Py_DECREF(tp);
 }

 static int