Commit 02e7dfde authored by Georg Brandl's avatar Georg Brandl

#7381: consistency update, and backport avoiding ``None >= 0`` check from py3k.

parent fe8df4fa
...@@ -136,7 +136,8 @@ check_output(*popenargs, **kwargs): ...@@ -136,7 +136,8 @@ check_output(*popenargs, **kwargs):
The arguments are the same as for the Popen constructor. Example: The arguments are the same as for the Popen constructor. Example:
output = subprocess.check_output(["ls", "-l", "/dev/null"]) output = check_output(["ls", "-l", "/dev/null"])
Exceptions Exceptions
---------- ----------
...@@ -462,7 +463,8 @@ _active = [] ...@@ -462,7 +463,8 @@ _active = []
def _cleanup(): def _cleanup():
for inst in _active[:]: for inst in _active[:]:
if inst._internal_poll(_deadstate=sys.maxint) >= 0: res = inst._internal_poll(_deadstate=sys.maxint)
if res is not None and res >= 0:
try: try:
_active.remove(inst) _active.remove(inst)
except ValueError: except ValueError:
...@@ -517,11 +519,11 @@ def check_output(*popenargs, **kwargs): ...@@ -517,11 +519,11 @@ def check_output(*popenargs, **kwargs):
'crw-rw-rw- 1 root root 1, 3 Oct 18 2007 /dev/null\n' 'crw-rw-rw- 1 root root 1, 3 Oct 18 2007 /dev/null\n'
The stdout argument is not allowed as it is used internally. The stdout argument is not allowed as it is used internally.
To capture standard error in the result, use stderr=subprocess.STDOUT. To capture standard error in the result, use stderr=STDOUT.
>>> check_output(["/bin/sh", "-c", >>> check_output(["/bin/sh", "-c",
... "ls -l non_existent_file ; exit 0"], ... "ls -l non_existent_file ; exit 0"],
... stderr=subprocess.STDOUT) ... stderr=STDOUT)
'ls: non_existent_file: No such file or directory\n' 'ls: non_existent_file: No such file or directory\n'
""" """
if 'stdout' in kwargs: if 'stdout' in kwargs:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment