Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
03fcfbef
Commit
03fcfbef
authored
Sep 11, 2012
by
Barry Warsaw
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
- Issue #15906: Fix a regression in argparse caused by the preceding change,
when action='append', type='str' and default=[].
parent
a8a5b397
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
14 additions
and
0 deletions
+14
-0
Lib/argparse.py
Lib/argparse.py
+1
-0
Lib/test/test_argparse.py
Lib/test/test_argparse.py
+10
-0
Misc/NEWS
Misc/NEWS
+3
-0
No files found.
Lib/argparse.py
View file @
03fcfbef
...
...
@@ -1948,6 +1948,7 @@ class ArgumentParser(_AttributeHolder, _ActionsContainer):
# twice (which may fail) if the argument was given, but
# only if it was defined already in the namespace
if
(
action
.
default
is
not
None
and
isinstance
(
action
,
_StoreAction
)
and
hasattr
(
namespace
,
action
.
dest
)
and
action
.
default
is
getattr
(
namespace
,
action
.
dest
)):
setattr
(
namespace
,
action
.
dest
,
...
...
Lib/test/test_argparse.py
View file @
03fcfbef
...
...
@@ -4480,6 +4480,16 @@ class TestTypeFunctionCallWithNonStringDefault(TestCase):
args
=
parser
.
parse_args
([])
self
.
assertEqual
(
NS
(
foo
=
'foo_converted'
),
args
)
def
test_issue_15906
(
self
):
# Issue #15906: When action='append', type=str, default=[] are
# providing, the dest value was the string representation "[]" when it
# should have been an empty list.
parser
=
argparse
.
ArgumentParser
()
parser
.
add_argument
(
'--test'
,
dest
=
'test'
,
type
=
str
,
default
=
[],
action
=
'append'
)
args
=
parser
.
parse_args
([])
self
.
assertEqual
(
args
.
test
,
[])
# ======================
# parse_known_args tests
# ======================
...
...
Misc/NEWS
View file @
03fcfbef
...
...
@@ -119,6 +119,9 @@ Library
especially problematic for the FileType type, as a default file would always
be opened, even if a file argument was specified on the command line.
- Issue #15906: Fix a regression in argparse caused by the preceding change,
when action='
append
', type='
str
' and default=[].
- Issue #13370: Ensure that ctypes works on Mac OS X when Python is
compiled using the clang compiler
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment