Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
0866bb68
Commit
0866bb68
authored
Sep 06, 2013
by
Ethan Furman
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Close #18924: Block naive attempts to change an Enum member.
parent
46abcaa5
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
18 additions
and
0 deletions
+18
-0
Lib/enum.py
Lib/enum.py
+13
-0
Lib/test/test_enum.py
Lib/test/test_enum.py
+5
-0
No files found.
Lib/enum.py
View file @
0866bb68
...
...
@@ -263,6 +263,19 @@ class EnumMeta(type):
def
__repr__
(
cls
):
return
"<enum %r>"
%
cls
.
__name__
def
__setattr__
(
cls
,
name
,
value
):
"""Block attempts to reassign Enum members.
A simple assignment to the class namespace only changes one of the
several possible ways to get an Enum member from the Enum class,
resulting in an inconsistent Enumeration.
"""
member_map
=
cls
.
__dict__
.
get
(
'_member_map_'
,
{})
if
name
in
member_map
:
raise
AttributeError
(
'Cannot reassign members.'
)
super
().
__setattr__
(
name
,
value
)
def
_create_
(
cls
,
class_name
,
names
=
None
,
*
,
module
=
None
,
type
=
None
):
"""Convenience method to create a new Enum class.
...
...
Lib/test/test_enum.py
View file @
0866bb68
...
...
@@ -152,6 +152,11 @@ class TestEnum(unittest.TestCase):
with
self
.
assertRaises
(
AttributeError
):
Season
.
SPRING
.
value
=
2
def
test_changing_member
(
self
):
Season
=
self
.
Season
with
self
.
assertRaises
(
AttributeError
):
Season
.
WINTER
=
'really cold'
def
test_invalid_names
(
self
):
with
self
.
assertRaises
(
ValueError
):
class
Wrong
(
Enum
):
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment