Commit 0c9050c2 authored by Raymond Hettinger's avatar Raymond Hettinger

Separate key creation logic from the sequence class that memoizes its hash value.

parent ca75b000
...@@ -142,30 +142,35 @@ except ImportError: ...@@ -142,30 +142,35 @@ except ImportError:
_CacheInfo = namedtuple("CacheInfo", ["hits", "misses", "maxsize", "currsize"]) _CacheInfo = namedtuple("CacheInfo", ["hits", "misses", "maxsize", "currsize"])
class _CacheKey(list): class _HashedSeq(list):
'Make a cache key from optionally typed positional and keyword arguments'
__slots__ = 'hashvalue' __slots__ = 'hashvalue'
def __init__(self, args, kwds, typed, def __init__(self, tup, hash=hash):
kwd_mark = (object(),), self[:] = tup
sorted=sorted, tuple=tuple, type=type, hash=hash): self.hashvalue = hash(tup)
key = args
if kwds:
sorted_items = sorted(kwds.items())
key += kwd_mark
for item in sorted_items:
key += item
if typed:
key += tuple(type(v) for v in args)
if kwds:
key += tuple(type(v) for k, v in sorted_items)
self[:] = key
self.hashvalue = hash(key) # so we only have to hash just once
def __hash__(self): def __hash__(self):
return self.hashvalue return self.hashvalue
def _make_key(args, kwds, typed,
kwd_mark = (object(),),
fasttypes = {int, str, frozenset, type(None)},
sorted=sorted, tuple=tuple, type=type, len=len):
'Make a cache key from optionally typed positional and keyword arguments'
key = args
if kwds:
sorted_items = sorted(kwds.items())
key += kwd_mark
for item in sorted_items:
key += item
if typed:
key += tuple(type(v) for v in args)
if kwds:
key += tuple(type(v) for k, v in sorted_items)
elif len(key) == 1 and type(key[0]) in fasttypes:
return key[0]
return _HashedSeq(key)
def lru_cache(maxsize=128, typed=False): def lru_cache(maxsize=128, typed=False):
"""Least-recently-used cache decorator. """Least-recently-used cache decorator.
...@@ -193,7 +198,7 @@ def lru_cache(maxsize=128, typed=False): ...@@ -193,7 +198,7 @@ def lru_cache(maxsize=128, typed=False):
# Constants shared by all lru cache instances: # Constants shared by all lru cache instances:
sentinel = object() # unique object used to signal cache misses sentinel = object() # unique object used to signal cache misses
make_key = _CacheKey # build a key from the function arguments make_key = _make_key # build a key from the function arguments
PREV, NEXT, KEY, RESULT = 0, 1, 2, 3 # names for the link fields PREV, NEXT, KEY, RESULT = 0, 1, 2, 3 # names for the link fields
def decorating_function(user_function): def decorating_function(user_function):
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment