Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
0d231eda
Commit
0d231eda
authored
23 years ago
by
Guido van Rossum
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
A totally new way to do the __new__ wrapper. This should address the
problem brought up in SF bug #444229.
parent
45900492
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
45 additions
and
34 deletions
+45
-34
Objects/typeobject.c
Objects/typeobject.c
+45
-34
No files found.
Objects/typeobject.c
View file @
0d231eda
...
...
@@ -938,31 +938,6 @@ add_wrappers(PyTypeObject *type, struct wrapperbase *base, void *wrapped)
return
0
;
}
static
int
add_staticmethodwrappers
(
PyTypeObject
*
type
,
struct
wrapperbase
*
base
,
void
*
wrapped
)
{
PyObject
*
dict
=
type
->
tp_defined
;
PyObject
*
sm
;
for
(;
base
->
name
!=
NULL
;
base
++
)
{
PyObject
*
descr
;
if
(
PyDict_GetItemString
(
dict
,
base
->
name
))
continue
;
descr
=
PyDescr_NewWrapper
(
type
->
ob_type
,
base
,
wrapped
);
if
(
descr
==
NULL
)
return
-
1
;
sm
=
PyStaticMethod_New
(
descr
);
Py_DECREF
(
descr
);
if
(
sm
==
NULL
)
return
-
1
;
if
(
PyDict_SetItemString
(
dict
,
base
->
name
,
sm
)
<
0
)
return
-
1
;
Py_DECREF
(
sm
);
}
return
0
;
}
static
int
add_members
(
PyTypeObject
*
type
,
struct
memberlist
*
memb
)
{
...
...
@@ -1197,7 +1172,7 @@ PyType_InitDict(PyTypeObject *type)
}
/* Initialize the base class */
if
(
base
)
{
if
(
base
&&
base
->
tp_dict
==
NULL
)
{
if
(
PyType_InitDict
(
base
)
<
0
)
return
-
1
;
}
...
...
@@ -1853,18 +1828,55 @@ static struct wrapperbase tab_init[] = {
};
static
PyObject
*
wrap_new
(
PyObject
*
type
,
PyObject
*
args
,
void
*
wrapped
)
tp_new_wrapper
(
PyObject
*
self
,
PyObject
*
args
,
PyObject
*
kwds
)
{
newfunc
new
=
(
newfunc
)
wrapped
;
return
new
((
PyTypeObject
*
)
type
,
args
,
NULL
);
PyTypeObject
*
type
,
*
subtype
;
PyObject
*
arg0
,
*
res
;
if
(
self
==
NULL
||
!
PyType_Check
(
self
))
Py_FatalError
(
"__new__() called with non-type 'self'"
);
type
=
(
PyTypeObject
*
)
self
;
if
(
!
PyTuple_Check
(
args
)
||
PyTuple_GET_SIZE
(
args
)
<
1
)
{
PyErr_SetString
(
PyExc_TypeError
,
"T.__new__(): not enough arguments"
);
return
NULL
;
}
arg0
=
PyTuple_GET_ITEM
(
args
,
0
);
if
(
!
PyType_Check
(
arg0
))
{
PyErr_SetString
(
PyExc_TypeError
,
"T.__new__(S): S is not a type object"
);
return
NULL
;
}
subtype
=
(
PyTypeObject
*
)
arg0
;
if
(
!
PyType_IsSubtype
(
subtype
,
type
))
{
PyErr_SetString
(
PyExc_TypeError
,
"T.__new__(S): S is not a subtype of T"
);
return
NULL
;
}
args
=
PyTuple_GetSlice
(
args
,
1
,
PyTuple_GET_SIZE
(
args
));
if
(
args
==
NULL
)
return
NULL
;
res
=
type
->
tp_new
(
subtype
,
args
,
kwds
);
Py_DECREF
(
args
);
return
res
;
}
static
struct
wrapperbase
tab_new
[]
=
{
{
"__new__"
,
(
wrapperfunc
)
wrap_new
,
"T.__new__(
) -> an object with type
T"
},
static
struct
PyMethodDef
tp_new_methoddef
[]
=
{
{
"__new__"
,
(
PyCFunction
)
tp_new_wrapper
,
METH_KEYWORDS
,
"T.__new__(
S, ...) -> a new object with type S, a subtype of
T"
},
{
0
}
};
static
int
add_tp_new_wrapper
(
PyTypeObject
*
type
)
{
PyObject
*
func
=
PyCFunction_New
(
tp_new_methoddef
,
(
PyObject
*
)
type
);
if
(
func
==
NULL
)
return
-
1
;
return
PyDict_SetItemString
(
type
->
tp_defined
,
"__new__"
,
func
);
}
static
int
add_operators
(
PyTypeObject
*
type
)
{
...
...
@@ -1955,8 +1967,7 @@ add_operators(PyTypeObject *type)
ADD
(
type
->
tp_init
,
tab_init
);
if
(
type
->
tp_new
!=
NULL
)
add_staticmethodwrappers
(
type
,
tab_new
,
(
void
*
)(
type
->
tp_new
));
add_tp_new_wrapper
(
type
);
return
0
;
}
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment