Commit 0d28a61d authored by Roger Serwy's avatar Roger Serwy

#17614: IDLE no longer raises exception when quickly closing a file.

parents ed3a3035 d7c9d9cd
...@@ -111,12 +111,13 @@ class PyShellEditorWindow(EditorWindow): ...@@ -111,12 +111,13 @@ class PyShellEditorWindow(EditorWindow):
self.breakpointPath = os.path.join(idleConf.GetUserCfgDir(), self.breakpointPath = os.path.join(idleConf.GetUserCfgDir(),
'breakpoints.lst') 'breakpoints.lst')
# whenever a file is changed, restore breakpoints # whenever a file is changed, restore breakpoints
if self.io.filename: self.restore_file_breaks()
def filename_changed_hook(old_hook=self.io.filename_change_hook, def filename_changed_hook(old_hook=self.io.filename_change_hook,
self=self): self=self):
self.restore_file_breaks() self.restore_file_breaks()
old_hook() old_hook()
self.io.set_filename_change_hook(filename_changed_hook) self.io.set_filename_change_hook(filename_changed_hook)
if self.io.filename:
self.restore_file_breaks()
rmenu_specs = [ rmenu_specs = [
("Cut", "<<cut>>", "rmenu_check_cut"), ("Cut", "<<cut>>", "rmenu_check_cut"),
...@@ -233,6 +234,9 @@ class PyShellEditorWindow(EditorWindow): ...@@ -233,6 +234,9 @@ class PyShellEditorWindow(EditorWindow):
def restore_file_breaks(self): def restore_file_breaks(self):
self.text.update() # this enables setting "BREAK" tags to be visible self.text.update() # this enables setting "BREAK" tags to be visible
if self.io is None:
# can happen if IDLE closes due to the .update() call
return
filename = self.io.filename filename = self.io.filename
if filename is None: if filename is None:
return return
......
...@@ -19,6 +19,8 @@ Core and Builtins ...@@ -19,6 +19,8 @@ Core and Builtins
Library Library
------- -------
- Issue #17614: IDLE no longer raises exception when quickly closing a file.
- Issue #6698: IDLE now opens just an editor window when configured to do so. - Issue #6698: IDLE now opens just an editor window when configured to do so.
- Issue #8900: Using keyboard shortcuts in IDLE to open a file no longer - Issue #8900: Using keyboard shortcuts in IDLE to open a file no longer
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment