Commit 0e41148c authored by Walter Dörwald's avatar Walter Dörwald

Use O_APPEND flag instead of seeking, when append

mode is specified.
parent 5b1284d0
...@@ -230,6 +230,11 @@ fileio_init(PyObject *oself, PyObject *args, PyObject *kwds) ...@@ -230,6 +230,11 @@ fileio_init(PyObject *oself, PyObject *args, PyObject *kwds)
flags |= O_BINARY; flags |= O_BINARY;
#endif #endif
#ifdef O_APPEND
if (append)
flags |= O_APPEND;
#endif
if (fd >= 0) { if (fd >= 0) {
self->fd = fd; self->fd = fd;
} }
...@@ -242,18 +247,6 @@ fileio_init(PyObject *oself, PyObject *args, PyObject *kwds) ...@@ -242,18 +247,6 @@ fileio_init(PyObject *oself, PyObject *args, PyObject *kwds)
PyErr_SetFromErrnoWithFilename(PyExc_IOError, name); PyErr_SetFromErrnoWithFilename(PyExc_IOError, name);
goto error; goto error;
} }
if (append) {
int result;
Py_BEGIN_ALLOW_THREADS
errno = 0;
result = lseek(self->fd, 0, SEEK_END);
Py_END_ALLOW_THREADS
if (result < 0) {
close(self->fd);
PyErr_SetFromErrnoWithFilename(PyExc_IOError, name);
goto error;
}
}
} }
goto done; goto done;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment