Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
0ee9baa8
Commit
0ee9baa8
authored
Dec 03, 2013
by
Tim Peters
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Issue #19138: doctest's IGNORE_EXCEPTION_DETAIL now allows no detail at all.
Grafted from c80083ad142d.
parent
7b2ac609
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
60 additions
and
4 deletions
+60
-4
Lib/doctest.py
Lib/doctest.py
+29
-4
Lib/test/test_doctest.py
Lib/test/test_doctest.py
+27
-0
Misc/NEWS
Misc/NEWS
+4
-0
No files found.
Lib/doctest.py
View file @
0ee9baa8
...
...
@@ -326,6 +326,32 @@ def _comment_line(line):
else
:
return
'#'
def
_strip_exception_details
(
msg
):
# Support for IGNORE_EXCEPTION_DETAIL.
# Get rid of everything except the exception name; in particular, drop
# the possibly dotted module path (if any) and the exception message (if
# any). We assume that a colon is never part of a dotted name, or of an
# exception name.
# E.g., given
# "foo.bar.MyError: la di da"
# return "MyError"
# Or for "abc.def" or "abc.def:\n" return "def".
start
,
end
=
0
,
len
(
msg
)
# The exception name must appear on the first line.
i
=
msg
.
find
(
"
\
n
"
)
if
i
>=
0
:
end
=
i
# retain up to the first colon (if any)
i
=
msg
.
find
(
':'
,
0
,
end
)
if
i
>=
0
:
end
=
i
# retain just the exception name
i
=
msg
.
rfind
(
'.'
,
0
,
end
)
if
i
>=
0
:
start
=
i
+
1
return
msg
[
start
:
end
]
class
_OutputRedirectingPdb
(
pdb
.
Pdb
):
"""
A specialized version of the python debugger that redirects stdout
...
...
@@ -1323,10 +1349,9 @@ class DocTestRunner:
# Another chance if they didn't care about the detail.
elif
self
.
optionflags
&
IGNORE_EXCEPTION_DETAIL
:
m1
=
re
.
match
(
r'(?:[^:]*\
.)?([^:]*:)
', example.exc_msg)
m2 = re.match(r'
(
?
:[
^
:]
*
\
.)
?
([
^
:]
*
:)
', exc_msg)
if m1 and m2 and check(m1.group(1), m2.group(1),
self.optionflags):
if
check
(
_strip_exception_details
(
example
.
exc_msg
),
_strip_exception_details
(
exc_msg
),
self
.
optionflags
):
outcome
=
SUCCESS
# Report the outcome.
...
...
Lib/test/test_doctest.py
View file @
0ee9baa8
...
...
@@ -1019,6 +1019,33 @@ But IGNORE_EXCEPTION_DETAIL does not allow a mismatch in the exception type:
ValueError: message
TestResults(failed=1, attempted=1)
If the exception does not have a message, you can still use
IGNORE_EXCEPTION_DETAIL to normalize the modules between Python 2 and 3:
>>> def f(x):
... r'''
... >>> from http.client import HTTPException
... >>> raise HTTPException() #doctest: +IGNORE_EXCEPTION_DETAIL
... Traceback (most recent call last):
... foo.bar.HTTPException
... '''
>>> test = doctest.DocTestFinder().find(f)[0]
>>> doctest.DocTestRunner(verbose=False).run(test)
TestResults(failed=0, attempted=2)
Note that a trailing colon doesn't matter either:
>>> def f(x):
... r'''
... >>> from http.client import HTTPException
... >>> raise HTTPException() #doctest: +IGNORE_EXCEPTION_DETAIL
... Traceback (most recent call last):
... foo.bar.HTTPException:
... '''
>>> test = doctest.DocTestFinder().find(f)[0]
>>> doctest.DocTestRunner(verbose=False).run(test)
TestResults(failed=0, attempted=2)
If an exception is raised but not expected, then it is reported as an
unexpected exception:
...
...
Misc/NEWS
View file @
0ee9baa8
...
...
@@ -15,6 +15,10 @@ Core and Builtins
Library
-------
- Issue #19138: doctest'
s
IGNORE_EXCEPTION_DETAIL
now
allows
a
match
when
no
exception
detail
exists
(
no
colon
following
the
exception
's name, or
a colon does follow but no text follows the colon).
- Issue #16231: Fixed pickle.Pickler to only fallback to its default pickling
behaviour when Pickler.persistent_id returns None, but not for any other
false values. This allows false values other than None to be used as
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment