Commit 11384393 authored by Serhiy Storchaka's avatar Serhiy Storchaka

Issue #25203: Failed readline.set_completer_delims() no longer left the

 module in inconsistent state.
parent 87d0066f
...@@ -81,6 +81,9 @@ Core and Builtins ...@@ -81,6 +81,9 @@ Core and Builtins
Library Library
------- -------
- Issue #25203: Failed readline.set_completer_delims() no longer left the
module in inconsistent state.
- Prevent overflow in _Unpickler_Read. - Prevent overflow in _Unpickler_Read.
- Issue #25047: The XML encoding declaration written by Element Tree now - Issue #25047: The XML encoding declaration written by Element Tree now
......
...@@ -427,10 +427,11 @@ set_completer_delims(PyObject *self, PyObject *args) ...@@ -427,10 +427,11 @@ set_completer_delims(PyObject *self, PyObject *args)
/* Keep a reference to the allocated memory in the module state in case /* Keep a reference to the allocated memory in the module state in case
some other module modifies rl_completer_word_break_characters some other module modifies rl_completer_word_break_characters
(see issue #17289). */ (see issue #17289). */
free(completer_word_break_characters); break_chars = strdup(break_chars);
completer_word_break_characters = strdup(break_chars); if (break_chars) {
if (completer_word_break_characters) { free(completer_word_break_characters);
rl_completer_word_break_characters = completer_word_break_characters; completer_word_break_characters = break_chars;
rl_completer_word_break_characters = break_chars;
Py_RETURN_NONE; Py_RETURN_NONE;
} }
else else
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment