Commit 11470b6d authored by Victor Stinner's avatar Victor Stinner Committed by GitHub

bpo-30106: Fix tearDown() of test_asyncore (#1194)

Call asyncore.close_all() with ignore_all=True in the tearDown()
method of the test_asyncore base test case. It should prevent keeping
alive sockets in asyncore.socket_map if close() fails with an
unexpected error.

Revert also an unwanted change of my previous commit: remove name
parameter of Thread in test_quick_connect().
parent d13d5474
......@@ -502,7 +502,7 @@ class BaseClient(BaseTestHandler):
class BaseTestAPI:
def tearDown(self):
asyncore.close_all()
asyncore.close_all(ignore_all=True)
def loop_waiting_for_flag(self, instance, timeout=5):
timeout = float(timeout) / 100
......@@ -782,7 +782,7 @@ class BaseTestAPI:
server = BaseServer(self.family, self.addr)
t = threading.Thread(target=lambda: asyncore.loop(timeout=0.1,
count=500), name="ident")
count=500))
t.start()
try:
with socket.socket(self.family, socket.SOCK_STREAM) as s:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment