Commit 137b0632 authored by Pablo Galindo's avatar Pablo Galindo Committed by GitHub

bpo-34997: Fix test_logging.ConfigDictTest.test_out_of_order (GH-9913)

When runnint test_logging with --huntrleaks after commit
18fb1fb9, test_out_of_order fails
to raise ValueError due to the fact that the new test
test_out_of_order_with_dollar_style mutates the out_of_order
dictionary. Even if the test copies the dictionary first, the mutation
is done in a very deep level so the original one is also affected.
parent 1a4a10d9
...@@ -25,6 +25,7 @@ import logging.config ...@@ -25,6 +25,7 @@ import logging.config
import codecs import codecs
import configparser import configparser
import copy
import datetime import datetime
import pathlib import pathlib
import pickle import pickle
...@@ -3278,7 +3279,7 @@ class ConfigDictTest(BaseTest): ...@@ -3278,7 +3279,7 @@ class ConfigDictTest(BaseTest):
self.assertRaises(ValueError, self.apply_config, self.out_of_order) self.assertRaises(ValueError, self.apply_config, self.out_of_order)
def test_out_of_order_with_dollar_style(self): def test_out_of_order_with_dollar_style(self):
config = self.out_of_order.copy() config = copy.deepcopy(self.out_of_order)
config['formatters']['mySimpleFormatter']['format'] = "${asctime} (${name}) ${levelname}: ${message}" config['formatters']['mySimpleFormatter']['format'] = "${asctime} (${name}) ${levelname}: ${message}"
self.apply_config(config) self.apply_config(config)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment