Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
142b3f56
Commit
142b3f56
authored
Jun 25, 2010
by
Benjamin Peterson
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
only take into account positional arguments count in related error messages
parent
c6f5f74f
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
16 additions
and
6 deletions
+16
-6
Lib/inspect.py
Lib/inspect.py
+1
-1
Lib/test/test_extcall.py
Lib/test/test_extcall.py
+2
-2
Lib/test/test_keywordonlyarg.py
Lib/test/test_keywordonlyarg.py
+8
-0
Misc/NEWS
Misc/NEWS
+2
-0
Python/ceval.c
Python/ceval.c
+3
-3
No files found.
Lib/inspect.py
View file @
142b3f56
...
...
@@ -959,7 +959,7 @@ def getcallargs(func, *positional, **named):
else
:
arg2value
[
varargs
]
=
()
elif
0
<
num_args
<
num_pos
:
raise
TypeError
(
'%s() takes %s %d %s (%d given)'
%
(
raise
TypeError
(
'%s() takes %s %d
positional
%s (%d given)'
%
(
f_name
,
'at most'
if
defaults
else
'exactly'
,
num_args
,
'arguments'
if
num_args
>
1
else
'argument'
,
num_total
))
elif
num_args
==
0
and
num_total
:
...
...
Lib/test/test_extcall.py
View file @
142b3f56
...
...
@@ -279,13 +279,13 @@ The number of arguments passed in includes keywords:
>>> f(6, a=4, *(1, 2, 3))
Traceback (most recent call last):
...
TypeError: f() takes exactly 1 argument (5 given)
TypeError: f() takes exactly 1
positional
argument (5 given)
>>> def f(a, *, kw):
... pass
>>> f(6, 4, kw=4)
Traceback (most recent call last):
...
TypeError: f() takes exactly
2 arguments
(3 given)
TypeError: f() takes exactly
1 positional argument
(3 given)
"""
import
sys
...
...
Lib/test/test_keywordonlyarg.py
View file @
142b3f56
...
...
@@ -73,6 +73,14 @@ class KeywordOnlyArgTestCase(unittest.TestCase):
fundef3
+=
"lastarg):
\
n
pass
\
n
"
compile
(
fundef3
,
"<test>"
,
"single"
)
def
testTooManyPositionalErrorMessage
(
self
):
def
f
(
a
,
b
=
None
,
*
,
c
=
None
):
pass
with
self
.
assertRaises
(
TypeError
)
as
exc
:
f
(
1
,
2
,
3
)
expected
=
"f() takes at most 2 positional arguments (3 given)"
self
.
assertEqual
(
str
(
exc
.
exception
),
expected
)
def
testSyntaxErrorForFunctionCall
(
self
):
self
.
assertRaisesSyntaxError
(
"f(p, k=1, p2)"
)
self
.
assertRaisesSyntaxError
(
"f(p, k1=50, *(1,2), k1=100)"
)
...
...
Misc/NEWS
View file @
142b3f56
...
...
@@ -12,6 +12,8 @@ What's New in Python 3.2 Alpha 1?
Core and Builtins
-----------------
- Be more specific in error messages about positional arguments.
- Issue #8949: "z" format of PyArg_Parse*() functions doesn't accept bytes
objects, as described in the documentation.
...
...
Python/ceval.c
View file @
142b3f56
...
...
@@ -3100,11 +3100,11 @@ PyEval_EvalCodeEx(PyCodeObject *co, PyObject *globals, PyObject *locals,
if
(
!
(
co
->
co_flags
&
CO_VARARGS
))
{
PyErr_Format
(
PyExc_TypeError
,
"%U() takes %s %d "
"argument%s (%d given)"
,
"
positional
argument%s (%d given)"
,
co
->
co_name
,
defcount
?
"at most"
:
"exactly"
,
total_args
,
total_args
==
1
?
""
:
"s"
,
co
->
co_argcount
,
co
->
co_argcount
==
1
?
""
:
"s"
,
argcount
+
kwcount
);
goto
fail
;
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment