Commit 1456fde6 authored by Gustavo Niemeyer's avatar Gustavo Niemeyer

Fixed bug

[#495695] webbrowser.py: selection of browser

* Lib/webbrowser.py
  Only include graphic browsers in _tryorder if DISPLAY is set. Also,
  included skipstone support, as suggested by Fred in the mentioned bug.

* Misc/NEWS
  Mention fix and skipstone inclusion.
parent 3d654d6d
...@@ -261,8 +261,7 @@ class WindowsDefault: ...@@ -261,8 +261,7 @@ class WindowsDefault:
# the TERM and DISPLAY cases, because we might be running Python from inside # the TERM and DISPLAY cases, because we might be running Python from inside
# an xterm. # an xterm.
if os.environ.get("TERM") or os.environ.get("DISPLAY"): if os.environ.get("TERM") or os.environ.get("DISPLAY"):
_tryorder = ["galeon", "mozilla", "netscape", "kfm", _tryorder = ["links", "lynx", "w3m"]
"grail", "links", "lynx", "w3m",]
# Easy cases first -- register console browsers if we have them. # Easy cases first -- register console browsers if we have them.
if os.environ.get("TERM"): if os.environ.get("TERM"):
...@@ -278,6 +277,9 @@ if os.environ.get("TERM") or os.environ.get("DISPLAY"): ...@@ -278,6 +277,9 @@ if os.environ.get("TERM") or os.environ.get("DISPLAY"):
# X browsers have more in the way of options # X browsers have more in the way of options
if os.environ.get("DISPLAY"): if os.environ.get("DISPLAY"):
_tryorder = ["galeon", "skipstone", "mozilla", "netscape",
"kfm", "grail"] + _tryorder
# First, the Netscape series # First, the Netscape series
if _iscommand("mozilla"): if _iscommand("mozilla"):
register("mozilla", None, Netscape("mozilla")) register("mozilla", None, Netscape("mozilla"))
...@@ -293,6 +295,11 @@ if os.environ.get("TERM") or os.environ.get("DISPLAY"): ...@@ -293,6 +295,11 @@ if os.environ.get("TERM") or os.environ.get("DISPLAY"):
if _iscommand("galeon"): if _iscommand("galeon"):
register("galeon", None, Galeon("galeon")) register("galeon", None, Galeon("galeon"))
# Skipstone, another Gtk/Mozilla based browser
if _iscommand("skipstone"):
register("skipstone", None, GenericBrowser(
"skipstone '%s' >/dev/null &"))
# Konqueror/kfm, the KDE browser. # Konqueror/kfm, the KDE browser.
if _iscommand("kfm") or _iscommand("konqueror"): if _iscommand("kfm") or _iscommand("konqueror"):
register("kfm", Konqueror, Konqueror()) register("kfm", Konqueror, Konqueror())
......
...@@ -628,6 +628,10 @@ Library ...@@ -628,6 +628,10 @@ Library
the config file, including the contents of the referred filename in the config file, including the contents of the referred filename in
the "%verifyscript" section of the rpm spec file. the "%verifyscript" section of the rpm spec file.
- Fixed bug #495695: webbrowser module would run graphic browsers in a
unix environment even if DISPLAY was not set. Also, support for
skipstone browser was included.
Tools/Demos Tools/Demos
----------- -----------
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment