Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
187b0630
Commit
187b0630
authored
Sep 13, 2013
by
Senthil Kumaran
Browse files
Options
Browse Files
Download
Plain Diff
Fix http.server's request handling case on trailing '/'.
Patch contributed by Vajrasky Kok. Addresses Issue #17324
parents
5abf3d99
72c238e2
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
11 additions
and
0 deletions
+11
-0
Lib/http/server.py
Lib/http/server.py
+4
-0
Lib/test/test_httpservers.py
Lib/test/test_httpservers.py
+3
-0
Misc/NEWS
Misc/NEWS
+4
-0
No files found.
Lib/http/server.py
View file @
187b0630
...
...
@@ -788,6 +788,8 @@ class SimpleHTTPRequestHandler(BaseHTTPRequestHandler):
# abandon query parameters
path
=
path
.
split
(
'?'
,
1
)[
0
]
path
=
path
.
split
(
'#'
,
1
)[
0
]
# Don't forget explicit trailing slash when normalizing. Issue17324
trailing_slash
=
True
if
path
.
rstrip
().
endswith
(
'/'
)
else
False
path
=
posixpath
.
normpath
(
urllib
.
parse
.
unquote
(
path
))
words
=
path
.
split
(
'/'
)
words
=
filter
(
None
,
words
)
...
...
@@ -797,6 +799,8 @@ class SimpleHTTPRequestHandler(BaseHTTPRequestHandler):
head
,
word
=
os
.
path
.
split
(
word
)
if
word
in
(
os
.
curdir
,
os
.
pardir
):
continue
path
=
os
.
path
.
join
(
path
,
word
)
if
trailing_slash
:
path
+=
'/'
return
path
def
copyfile
(
self
,
source
,
outputfile
):
...
...
Lib/test/test_httpservers.py
View file @
187b0630
...
...
@@ -270,6 +270,9 @@ class SimpleHTTPServerTestCase(BaseTestCase):
#constructs the path relative to the root directory of the HTTPServer
response
=
self
.
request
(
self
.
tempdir_name
+
'/test'
)
self
.
check_status_and_reason
(
response
,
200
,
data
=
self
.
data
)
# check for trailing "/" which should return 404. See Issue17324
response
=
self
.
request
(
self
.
tempdir_name
+
'/test/'
)
self
.
check_status_and_reason
(
response
,
404
)
response
=
self
.
request
(
self
.
tempdir_name
+
'/'
)
self
.
check_status_and_reason
(
response
,
200
)
response
=
self
.
request
(
self
.
tempdir_name
)
...
...
Misc/NEWS
View file @
187b0630
...
...
@@ -10,6 +10,10 @@ Core and Builtins
Library
-------
-
Issue
#
17324
:
Fix
http
.
server
's request handling case on trailing '
/
'. Patch
contributed by Vajrasky Kok.
- Issue #18784: The uuid module no more attempts to load libc via ctypes.CDLL,
if all necessary functions are already found in libuuid.
Patch by Evgeny Sologubov.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment