Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
1b57d96c
Commit
1b57d96c
authored
Sep 14, 2016
by
Berker Peksag
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Issue #26171: Prevent buffer overflow in get_data
Backport of 01ddd608b85c.
parent
9ee93511
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
0 deletions
+8
-0
Misc/NEWS
Misc/NEWS
+3
-0
Modules/zipimport.c
Modules/zipimport.c
+5
-0
No files found.
Misc/NEWS
View file @
1b57d96c
...
...
@@ -10,6 +10,9 @@ What's New in Python 3.3.7?
Core and Builtins
-----------------
- Issue #26171: Fix possible integer overflow and heap corruption in
zipimporter.get_data().
- Issue #25709: Fixed problem with in-place string concatenation and utf-8 cache.
- Issue #24407: Fix crash when dict is mutated while being updated.
...
...
Modules/zipimport.c
View file @
1b57d96c
...
...
@@ -1089,6 +1089,11 @@ get_data(PyObject *archive, PyObject *toc_entry)
PyMarshal_ReadShortFromFile
(
fp
);
/* local header size */
file_offset
+=
l
;
/* Start of file data */
if
(
data_size
>
LONG_MAX
-
1
)
{
fclose
(
fp
);
PyErr_NoMemory
();
return
NULL
;
}
bytes_size
=
compress
==
0
?
data_size
:
data_size
+
1
;
if
(
bytes_size
==
0
)
bytes_size
++
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment