Commit 1c1d1e2b authored by Raymond Hettinger's avatar Raymond Hettinger

Don't grow strings by concatenation. Use ''.join() instead.

parent f6cc6e6b
......@@ -207,13 +207,15 @@ length message::
totalsent = totalsent + sent
def myreceive(self):
msg = ''
while len(msg) < MSGLEN:
chunk = self.sock.recv(MSGLEN-len(msg))
chunks = []
bytes_recd = 0
while bytes_recd < MSGLEN:
chunk = self.sock.recv(min(MSGLEN - bytes_recd, 2048))
if chunk == '':
raise RuntimeError("socket connection broken")
msg = msg + chunk
return msg
chucks.append(chunk)
bytes_recd = bytes_recd + len(chunk)
return ''.join(chunks)
The sending code here is usable for almost any messaging scheme - in Python you
send strings, and you can use ``len()`` to determine its length (even if it has
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment