bpo-34987: Fix a possible null pointer dereference in _pickle.c's save_reduce(). (GH-9886)

25d38978 · Zackery Spytz · Serhiy Storchaka · 5b25f1d0 · 25d38978
Commit 25d38978 authored Dec 05, 2018 by Zackery Spytz Committed by Serhiy Storchaka Dec 05, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 1 deletion

Modules/_pickle.c Modules/_pickle.c +4 -1

No files found.
--- a/Modules/_pickle.c
+++ b/Modules/_pickle.c
@@ -3840,7 +3840,10 @@ save_reduce(PicklerObject *self, PyObject *args, PyObject *obj)

        if (obj != NULL) {
            obj_class = get_class(obj);
-            p = obj_class != cls;    /* true iff a problem */
+            if (obj_class == NULL) {
+                return -1;
+            }
+            p = obj_class != cls;
            Py_DECREF(obj_class);
            if (p) {
                PyErr_SetString(st->PicklingError, "args[0] from "