Commit 270a21fd authored by Xiang Zhang's avatar Xiang Zhang

Issue #28950: Disallow -j0 combined with -T/-l/-M in regrtest.

parent 509476b3
...@@ -380,11 +380,11 @@ def _parse_args(args, **kwargs): ...@@ -380,11 +380,11 @@ def _parse_args(args, **kwargs):
if ns.single and ns.fromfile: if ns.single and ns.fromfile:
parser.error("-s and -f don't go together!") parser.error("-s and -f don't go together!")
if ns.use_mp and ns.trace: if ns.use_mp is not None and ns.trace:
parser.error("-T and -j don't go together!") parser.error("-T and -j don't go together!")
if ns.use_mp and ns.findleaks: if ns.use_mp is not None and ns.findleaks:
parser.error("-l and -j don't go together!") parser.error("-l and -j don't go together!")
if ns.use_mp and ns.memlimit: if ns.use_mp is not None and ns.memlimit:
parser.error("-M and -j don't go together!") parser.error("-M and -j don't go together!")
if ns.failfast and not (ns.verbose or ns.verbose3): if ns.failfast and not (ns.verbose or ns.verbose3):
parser.error("-G/--failfast needs either -v or -W") parser.error("-G/--failfast needs either -v or -W")
......
...@@ -200,6 +200,9 @@ class ParseArgsTestCase(unittest.TestCase): ...@@ -200,6 +200,9 @@ class ParseArgsTestCase(unittest.TestCase):
self.checkError([opt, '2', '-T'], "don't go together") self.checkError([opt, '2', '-T'], "don't go together")
self.checkError([opt, '2', '-l'], "don't go together") self.checkError([opt, '2', '-l'], "don't go together")
self.checkError([opt, '2', '-M', '4G'], "don't go together") self.checkError([opt, '2', '-M', '4G'], "don't go together")
self.checkError([opt, '0', '-T'], "don't go together")
self.checkError([opt, '0', '-l'], "don't go together")
self.checkError([opt, '0', '-M', '4G'], "don't go together")
def test_coverage(self): def test_coverage(self):
for opt in '-T', '--coverage': for opt in '-T', '--coverage':
......
...@@ -549,6 +549,9 @@ Documentation ...@@ -549,6 +549,9 @@ Documentation
Tests Tests
----- -----
- Issue #28950: Disallow -j0 to be combined with -T/-l/-M in regrtest
command line arguments.
- Issue #28666: Now test.support.rmtree is able to remove unwritable or - Issue #28666: Now test.support.rmtree is able to remove unwritable or
unreadable directories. unreadable directories.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment