Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
2942b909
Commit
2942b909
authored
Feb 07, 2018
by
INADA Naoki
Committed by
GitHub
Feb 07, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
bpo-32616: Disable computed gotos by default for clang < 5 (GH-5574)
parent
0a18422b
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
12 additions
and
2 deletions
+12
-2
Misc/NEWS.d/next/Build/2018-02-07-11-24-38.bpo-32616.o7mFJ3.rst
...EWS.d/next/Build/2018-02-07-11-24-38.bpo-32616.o7mFJ3.rst
+2
-0
Python/ceval.c
Python/ceval.c
+10
-2
No files found.
Misc/NEWS.d/next/Build/2018-02-07-11-24-38.bpo-32616.o7mFJ3.rst
0 → 100644
View file @
2942b909
Disable computed gotos by default for clang < 5.0. It caused significant
performance regression.
Python/ceval.c
View file @
2942b909
...
...
@@ -689,11 +689,19 @@ PyObject *
PyEval_EvalFrameEx
(
PyFrameObject
*
f
,
int
throwflag
)
{
#ifdef DYNAMIC_EXECUTION_PROFILE
#undef USE_COMPUTED_GOTOS
#undef USE_COMPUTED_GOTOS
#endif
#ifdef HAVE_COMPUTED_GOTOS
#ifndef USE_COMPUTED_GOTOS
#define USE_COMPUTED_GOTOS 1
#if defined(__clang__) && (__clang_major__ < 5)
/* Computed gotos caused significant performance regression
* with clang < 5.0.
* https://bugs.python.org/issue32616
*/
#define USE_COMPUTED_GOTOS 0
#else
#define USE_COMPUTED_GOTOS 1
#endif
#endif
#else
#if defined(USE_COMPUTED_GOTOS) && USE_COMPUTED_GOTOS
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment